aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix delete_all when chained with joins.Rafael Mendonça França2012-04-104-17/+59
| | | | Closes #5202 and #919
* Merge pull request #5788 from Ask11/rails_new_helpSantiago Pastorino2012-04-092-3/+17
|\ | | | | "rails new -h" shows message in rails directory
| * "rails new -h" shows message in rails directoryask2012-04-092-3/+17
| |
* | Merge pull request #5787 from frankieroberto/itemscope-patchSantiago Pastorino2012-04-092-3/+3
|\ \ | | | | | | Adding itemscope to list of boolean attributes.
| * | Adding itemscope to list of boolean attributes.Frankie Roberto2012-04-092-3/+3
| |/ | | | | | | | | | | 'itemscope' is defined within HTML5 for use in microdata markup. See http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.ht ml#attr-itemscope
* / rewords the section about default_url_options in the Action Controller ↵Xavier Noria2012-04-091-3/+4
|/ | | | Overview guide
* Merge pull request #5783 from rafaelfranca/default_url_optionsSantiago Pastorino2012-04-083-4/+4
|\ | | | | Document that default_url_options must return a hash with symbolized keys
| * Document that default_url_options must return a hash with symbolizedRafael Mendonça França2012-04-091-0/+1
| | | | | | | | keys
| * default_url_options does not receive one argument anymoreRafael Mendonça França2012-04-083-4/+3
| |
* | Revert "Merge pull request #5750 from ahoward/master"Santiago Pastorino2012-04-082-28/+1
| | | | | | | | | | | | | | This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a. The reverted commit improved the performance in the wrong place, now we have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement.
* | Inline the symbolize_keys/stringify_keys methodsSantiago Pastorino2012-04-081-2/+10
| | | | | | | | | | | | user system total real symbolize_keys 5.980000 0.070000 6.050000 ( 6.048187) new_symbolize_keys 4.310000 0.050000 4.360000 ( 4.364745)
* | Remove Fixnum#to_sym support in 1.8.7Santiago Pastorino2012-04-081-1/+1
|/
* Merge pull request #5718 from benedikt/masterJeremy Kemper2012-04-084-6/+13
|\ | | | | Removes caching from ActiveRecord::Core::ClassMethods#relation
| * Adds test to check that circular preloading does not modify Model.unscoped ↵Benedikt Deicke2012-04-033-4/+8
| | | | | | | | (as described in #5667)
| * Removes caching from ActiveRecord::Core::ClassMethods#relationBenedikt Deicke2012-04-033-6/+9
| | | | | | | | | | | | | | | | | | | | | | The #relation method gets called in four places and the return value was instantly cloned in three of them. The only place that did not clone was ActiveRecord::Scoping::Default::ClassMethods#unscoped. This introduced a bug described in #5667 and should really clone the relation, too. This means all four places would clone the relation, so it doesn't make a lot of sense caching it in the first place. The four places with calls to relations are: activerecord/lib/active_record/scoping/default.rb:110:in `block in build_default_scope'" activerecord/lib/active_record/scoping/default.rb:42:in `unscoped'" activerecord/lib/active_record/scoping/named.rb:38:in `scoped'" activerecord/lib/active_record/scoping/named.rb:52:in `scope_attributes'"
* | Fix a couple more script[type=text/javascript] tests affected by #5748Jeremy Kemper2012-04-082-8/+8
| |
* | Merge pull request #5748 from ai/no_type_in_html5Jeremy Kemper2012-04-0820-196/+196
|\ \ | | | | | | Remove unnecessary in HTML 5 type attribute with default value
| * | Remove unnecessary in HTML 5 type attribute with default valueAndrey A.I. Sitnik2012-04-0520-196/+196
| | |
* | | Merge pull request #5773 from trevor/patch-1Vijay Dev2012-04-082-6/+6
|\ \ \ | | | | | | | | url in comments - active_support/core_ext/integer/time.rb
| * | | update stdlib doc urls in comments - ↵Trevor Wennblom2012-04-072-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | active_support/core_ext/[integer|numeric]/time.rb http://stdlib.rubyonrails.org/ last updated in 2005
* | | | adds a new test case for titleizeXavier Noria2012-04-081-0/+1
| | | |
* | | | Merge pull request #5759 from ↵Piotr Sarnacki2012-04-071-7/+7
|\ \ \ \ | |/ / / |/| | | | | | | | | | | romanvbabenko/refactor/rails_module_singleton_class_varibles Class variables has been fixed to Singleton instance variables at Rails ...
| * | | Class variables has been fixed to Singleton instance variables at Rails moduleRoman V. Babenko2012-04-061-7/+7
| | | |
* | | | Merge pull request #5772 from lest/patch-4Xavier Noria2012-04-071-6/+4
|\ \ \ \ | | | | | | | | | | use extract_options! in cycle helper
| * | | | use extract_options! in cycle helperSergey Nartimov2012-04-071-6/+4
| | | | |
* | | | | revises the regexp used in titleizeXavier Noria2012-04-072-13/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The regexp used in titleize matches saxon genitive and other contractions, only to call capitalize on the captured text and have the apostrophe upcased which yields the apostrophe itself. It is more clear that the regexp matches just what it has to match.
* | | | | fix markup error [ci skip]Vijay Dev2012-04-081-1/+1
| | | | |
* | | | | avoid empty api pagesVijay Dev2012-04-083-4/+7
|/ / / /
* | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-04-075-14/+29
|\ \ \ \
| * | | | Don't use arel_table in published_and_commented example in querying guideRyan Bigg2012-04-071-1/+1
| | | | |
| * | | | Revert "Documents that ActiveRecord instances also support []/[]= methods ↵Vijay Dev2012-04-071-11/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | for reading/writing attributes" This reverts commit a49fe6ec2cb9f22a3b18d7db5ae2ee90325e9d09. Reason: The existing doc about using self[:attribute] is clear enough.
| * | | | Revert "Where migration can get wrong help added"Vijay Dev2012-04-071-10/+0
| | | | | | | | | | | | | | | | | | | | This reverts commit b11113f924d2eb2acbe836954d17a02163f45275.
| * | | | copy editing [ci skip]Vijay Dev2012-04-071-5/+4
| | | | |
| * | | | Fix example action dispatch in mime typeAlexey Vakhov2012-04-071-1/+1
| | | | |
| * | | | Documents that ActiveRecord instances also support []/[]= methods for ↵Rodrigo Rosenfeld Rosas2012-04-061-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reading/writing attributes Only write_attribute and read_attribute were documented and there was no mention to this alternative.
| * | | | Fix 'Everyday Git' linkAnil Wadghule2012-04-061-1/+1
| | | | |
| * | | | Better class namexyctka@gmail.com2012-04-061-2/+2
| | | | |
| * | | | Update Custom Exception Handler section of Internationalization guidexyctka@gmail.com2012-04-061-5/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous example with just_raise_that_exception method stopped working because MissingTranslation is not an instance of Exception class any more, but has a +to_exception+ method. Also the cleaner way is to re-raise only the desired exception, passing everything else to the default ExceptionHandler. Additionally this re-raising conflicts with Pluralization backend thus we have to add a check that certain missing translation keys should be ignored allowing the backend to fall back to the default pluralization rule.
| * | | | Where migration can get wrong help addedSandip Ransing2012-04-061-0/+10
| | | | |
| * | | | Improvement to migration guideSandip Ransing2012-04-061-6/+6
| | | | |
* | | | | Merge pull request #5766 from lest/patch-4Vijay Dev2012-04-071-1/+1
|\ \ \ \ \ | |_|/ / / |/| | | | pass default value as argument to fetch
| * | | | pass default value as argument to fetchSergey Nartimov2012-04-061-1/+1
|/ / / /
* | | | revises requires of some AS deprecation filesXavier Noria2012-04-053-3/+4
| | | |
* | | | documents the contract for the argument of AD::Routing::RouteSet#url_forXavier Noria2012-04-051-0/+1
| | | |
* | | | Merge pull request #5751 from rafaelfranca/fix-buildXavier Noria2012-04-053-2/+11
|\ \ \ \ | | | | | | | | | | Fix url_for when options is nil
| * | | | Make url_for work when option is nil and default_url_options hasRafael Mendonça França2012-04-052-1/+10
| | | | | | | | | | | | | | | | | | | | stringified keys
| * | | | Fix url_for when options is nilRafael Mendonça França2012-04-051-1/+1
| |/ / / | | | | | | | | | | | | | | | | RouteSet#url_for was modifying the options hash that belong to the caller
* | | | Merge pull request #5753 from ↵José Valim2012-04-052-1/+3
|\ \ \ \ | |/ / / |/| | | | | | | | | | | carlosantoniodasilva/as-remove-require-and-warnings Remove circular require from AS Deprecation, and fix warnings
| * | | Initialize variables in file update checker to avoid warningsCarlos Antonio da Silva2012-04-051-0/+3
| | | |
| * | | Remove not used require from as to avoid circular requiresCarlos Antonio da Silva2012-04-051-1/+0
|/ / /