aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafael Mendonça França <rafaelmfranca@gmail.com>2012-04-05 15:14:00 -0300
committerRafael Mendonça França <rafaelmfranca@gmail.com>2012-04-05 15:14:00 -0300
commitddbd1e4adbbdcbb6602839fbfd4ebe646393ce64 (patch)
tree20154e5c2fb5d41d7e27f60729eff07dcd39444b
parent8f4cf26d694587ff10ec25e07c3af1382513c47e (diff)
downloadrails-ddbd1e4adbbdcbb6602839fbfd4ebe646393ce64.tar.gz
rails-ddbd1e4adbbdcbb6602839fbfd4ebe646393ce64.tar.bz2
rails-ddbd1e4adbbdcbb6602839fbfd4ebe646393ce64.zip
Make url_for work when option is nil and default_url_options has
stringified keys
-rw-r--r--actionpack/lib/action_dispatch/routing/url_for.rb2
-rw-r--r--actionpack/test/controller/url_for_test.rb9
2 files changed, 10 insertions, 1 deletions
diff --git a/actionpack/lib/action_dispatch/routing/url_for.rb b/actionpack/lib/action_dispatch/routing/url_for.rb
index bab501f27c..12ae2456d6 100644
--- a/actionpack/lib/action_dispatch/routing/url_for.rb
+++ b/actionpack/lib/action_dispatch/routing/url_for.rb
@@ -145,7 +145,7 @@ module ActionDispatch
def url_for(options = nil)
case options
when nil
- _routes.url_for(url_options)
+ _routes.url_for(url_options.symbolize_keys)
when Hash
symbolized = {}
options.keys.each do |k|
diff --git a/actionpack/test/controller/url_for_test.rb b/actionpack/test/controller/url_for_test.rb
index 5b06d94d18..04a431c5c9 100644
--- a/actionpack/test/controller/url_for_test.rb
+++ b/actionpack/test/controller/url_for_test.rb
@@ -365,6 +365,15 @@ module AbstractController
assert_equal("/c/a", W.new.url_for(:controller => 'c', :action => 'a', :only_path => true))
end
+ def test_with_stringified_default_url_options_and_without_options
+ W.default_url_options['controller'] = 'c'
+ W.default_url_options['only_path'] = true
+ assert_equal("/c", W.new.url_for)
+
+ W.default_url_options['action'] = 'a'
+ assert_equal("/c/a", W.new.url_for)
+ end
+
def test_url_params_with_nil_to_param_are_not_in_url
assert_equal("/c/a", W.new.url_for(:only_path => true, :controller => 'c', :action => 'a', :id => Struct.new(:to_param).new(nil)))
end