Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | Inject the visitor rather than relying on other objects internals | Sean Griffin | 2015-12-17 | 2 | -2/+7 | |
| | | | | | | | | | | | | This is ultimately messy no matter what, and increases the coupling to the database backend, but we can at least contain it somewhat into an object that's already coupled. | |||||
| * | Delegate to Connection Visitor in WhereSQL Visitor | Edward Paget | 2015-12-17 | 2 | -1/+26 | |
|/ | | | | | | | | | | | | The WhereSQL visitor always uses the generic ToSQL visitor to create the where clause sql statement. This means that it'll miss database specific statements, such as 'ILIKE' in PostgreSQL. Since the `#where_sql` method is mainly used for ActiveRecord error reporting, this discrepancy could be confusing to users. This patch changes the WhereSQL visitor to use the its connection visitor to generate SQL for each statement in the SelectManager's wheres array. Then lets them be joined together with ' AND '. | |||||
* | Merge pull request #329 from vipulnsward/add-attribute-aggregate-tests | Rafael França | 2015-12-17 | 1 | -1/+10 | |
|\ | | | | | Added test for verifying proper sql generated by minimum aggregate method | |||||
| * | - Added test for verifying proper sql generated by minimum aggregate method. | Vipul A M | 2014-10-24 | 1 | -1/+10 | |
| | | ||||||
* | | Merge pull request #369 from codeodor/patch-1 | Rafael França | 2015-12-17 | 2 | -4/+10 | |
|\ \ | | | | | | | Improve error message when passed unsupported type | |||||
| * | | Use a specific exception for unsupported visits | Sammy Larbi | 2015-07-14 | 2 | -4/+10 | |
| | | | ||||||
| * | | Improve error message when passed unsupported type | Sammy Larbi | 2015-07-14 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge pull request #355 from jemc/patch-1 | Rafael Mendonça França | 2015-12-17 | 1 | -4/+2 | |
|\ \ \ | | | | | | | | | | | | | Test with rbx-2 on Travis-CI | |||||
| * | | | Use bundle exec on Travis-CI | Joe Eli McIlvain | 2015-02-19 | 1 | -1/+1 | |
| | | | | | | | | | | | | This avoids problems with using the wrong version of gems that are also included in the Ruby standard library, like `minitest` | |||||
| * | | | Test with rbx-2 on Travis-CI | Joe Eli McIlvain | 2015-02-19 | 1 | -4/+1 | |
| | | | | | | | | | | | | Using `rbx-2` is the recommended way to test with the 2.0 branch of Rubinius. | |||||
* | | | | Merge pull request #381 from carsonreinke/function_order | Rafael França | 2015-12-17 | 2 | -0/+10 | |
|\ \ \ \ | | | | | | | | | | | Add OrderPredications back into Nodes::Function | |||||
| * | | | | Add OrderPredications back into Nodes::Function (removed with deprecation of ↵ | Carson Reinke | 2015-07-23 | 2 | -0/+10 | |
| | |/ / | |/| | | | | | | | | | | Expression) | |||||
* | | | | Merge pull request #390 from yahonda/expr_oracle12 | Rafael França | 2015-12-17 | 1 | -2/+2 | |
|\ \ \ \ | | | | | | | | | | | No need to quote limit for Oracle12 visitor | |||||
| * | | | | No need to quote limit for Oracle12 visitor | Yasuo Honda | 2015-09-01 | 1 | -2/+2 | |
| | | | | | ||||||
* | | | | | Merge pull request #403 from kbrock/regexp | Aaron Patterson | 2015-12-16 | 7 | -23/+91 | |
|\ \ \ \ \ | | | | | | | | | | | | | Case insensitivite match/regular expressions | |||||
| * | | | | | test match predicate case sensitivity attribute | Keenan Brock | 2015-12-05 | 1 | -0/+6 | |
| | | | | | | ||||||
| * | | | | | introduce predicate {does_not_}matches_regexp | Keenan Brock | 2015-12-05 | 2 | -6/+21 | |
| | | | | | | ||||||
| * | | | | | use valid regular expression in regexp test | Keenan Brock | 2015-12-05 | 1 | -12/+12 | |
| | | | | | | ||||||
| * | | | | | Add case sensitive regexp | Keenan Brock | 2015-12-05 | 5 | -4/+33 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Explicitly declare if this is case sensitive or not currently postgres assumes case insensitive regexp no other databases support regexps | |||||
| * | | | | | Add case sensitive match | Keenan Brock | 2015-12-05 | 4 | -11/+29 | |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Explicitly declare if this is case sensitive or not most implementation assume case sensitive postgres assumes case insensitive | |||||
* | | | | | Merge pull request #396 from ur0/master | Sean Griffin | 2015-10-02 | 1 | -0/+0 | |
|\ \ \ \ \ | | | | | | | | | | | | | Rename MIT-LICENSE to MIT-LICENSE.txt | |||||
| * | | | | | Rename MIT-LICENSE to MIT-LICENSE.txt | Umang Raghuvanshi | 2015-10-02 | 1 | -0/+0 | |
|/ / / / / | | | | | | | | | | | | | | | | This renames MIT-LICENSE to MIT-LICENSE.txt. Closes #395, prevents builds from breaking. | |||||
* | | | | | Merge pull request #392 from maclover7/contributing | Rafael Mendonça França | 2015-09-09 | 4 | -6/+113 | |
|\ \ \ \ \ | | | | | | | | | | | | | Add CONTRIBUTING.md | |||||
| * | | | | | Add CONTRIBUTING.md [ci skip] | maclover7 | 2015-09-01 | 4 | -6/+113 | |
| |/ / / / | ||||||
* | | | | | Merge pull request #391 from yahonda/add_oracle12 | Rafael Mendonça França | 2015-09-01 | 1 | -1/+1 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Add "lib/arel/visitors/oracle12.rb" to its gemspec | |||||
| * | | | | Add "lib/arel/visitors/oracle12.rb" to its gemspec | Yasuo Honda | 2015-09-01 | 1 | -1/+1 | |
|/ / / / | ||||||
* | | | | Use bundled gems | Rafael Mendonça França | 2015-08-04 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Run with Ruby 2.2 | Rafael Mendonça França | 2015-08-04 | 1 | -1/+2 | |
| | | | | ||||||
* | | | | Improve travis configuration | Rafael Mendonça França | 2015-08-04 | 1 | -1/+10 | |
|/ / / | | | | | | | | | | | | | | | | | | | * Enable container builds * Notifications on Campfire * Bundle cache * Fast finish | |||||
* | | | Merge pull request #337 from yahonda/support_oracle12_top_n_2 | Aaron Patterson | 2015-07-14 | 4 | -2/+107 | |
|\ \ \ | | | | | | | | | Support Oracle 12c top-N query | |||||
| * | | | Create Arel::Visitors::Oracle12 to provide better top-N query | Yasuo Honda | 2015-06-19 | 3 | -0/+101 | |
| | | | | | | | | | | | | | | | | to support `FETCH FIRST n ROWS` and `OFFSET` for Oracle 12c database | |||||
| * | | | Extract visit_Arel_Nodes_SelectOptions | Yasuo Honda | 2015-06-19 | 1 | -2/+6 | |
| | | | | ||||||
* | | | | Merge pull request #361 from evgenim/master | Aaron Patterson | 2015-07-14 | 2 | -4/+40 | |
|\ \ \ \ | | | | | | | | | | | Fix visit_Arel_Nodes_FullOuterJoin/RightOuterJoin | |||||
| * | | | | Fix visit_Arel_Nodes_FullOuterJoin and visit_Arel_Nodes_RightOuterJoin to ↵ | evgenim | 2015-03-16 | 2 | -4/+40 | |
| | | | | | | | | | | | | | | | | | | | | make them work with collectors. | |||||
* | | | | | Merge pull request #377 from Eric-Guo/master | Rafael Mendonça França | 2015-07-13 | 2 | -3/+3 | |
|\ \ \ \ \ | | | | | | | | | | | | | Follow up #370 for Oracle, to fix undefined method `expr' for 10:Fixnum bug. | |||||
| * | | | | | Follow up #370 for Oracle, to fix undefined method `expr' for 10:Fixnum bug. | Eric Guo | 2015-07-14 | 2 | -3/+3 | |
|/ / / / / | ||||||
* | | | | | Merge pull request #374 from Shopify/no-need-to-quote-mysql-limit | Rafael Mendonça França | 2015-07-10 | 1 | -1/+1 | |
|\ \ \ \ \ | | | | | | | | | | | | | No need to quote MySQL LIMIT | |||||
| * | | | | | No need to quote MySQL LIMIT | Jean Boussier | 2015-07-10 | 1 | -1/+1 | |
|/ / / / / | ||||||
* | | | | | Merge pull request #372 from dzjuck/add_nodes_casted_to_gemspec | Rafael Mendonça França | 2015-06-24 | 1 | -1/+1 | |
|\ \ \ \ \ | |_|/ / / |/| | | | | Add nodes/casted.rb to gemspec file | |||||
| * | | | | Add nodes/casted.rb to gemspec file | Ilya Lavrov | 2015-06-24 | 1 | -1/+1 | |
|/ / / / | ||||||
* | | | | Merge pull request #370 from arthurnn/dont_quote_limit | Aaron Patterson | 2015-06-18 | 1 | -3/+3 | |
|\ \ \ \ | | | | | | | | | | | Dont need to quote limit | |||||
| * | | | | Dont need to quote limit | Arthur Neves | 2015-06-18 | 1 | -3/+3 | |
|/ / / / | ||||||
* | | | | Merge pull request #367 from vipulnsward/move-cased | Rafael Mendonça França | 2015-06-01 | 2 | -40/+41 | |
|\ \ \ \ | | | | | | | | | | | Move casted to its own file | |||||
| * | | | | Move casted to its own file | Vipul A M | 2015-05-31 | 2 | -40/+41 | |
|/ / / / | ||||||
* | | | | Merge pull request #362 from caldwecr/master | Rafael Mendonça França | 2015-03-23 | 1 | -1/+1 | |
|\ \ \ \ | |/ / / |/| | | | Fix a typo in the sql literal spec for grouped "and" equality | |||||
| * | | | Fix a typo in the sql literal spec for grouped "and" equality | Courtland Caldwell | 2015-03-23 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Merge pull request #356 from tamird/limited-delete | Rafael Mendonça França | 2015-02-23 | 7 | -5/+47 | |
|\ \ \ | |/ / |/| | | Limited delete | |||||
| * | | Special limited delete handling in MSSQL | Tamir Duberstein | 2015-02-23 | 3 | -2/+28 | |
| | | | | | | | | | | | | | | | Refernce: https://technet.microsoft.com/en-us/library/ms175486%28v=sql.105%29.aspx | |||||
| * | | Delete should respect 'limit' | Bradford Folkens | 2015-02-23 | 5 | -3/+19 | |
|/ / | | | | | | | | | Conflicts: lib/arel/visitors/to_sql.rb | |||||
* | | Change the interface of `having` to match that of `where` | Sean Griffin | 2015-01-27 | 10 | -29/+29 | |
| | | | | | | | | | | | | These two clauses have nearly identical semantics with regards to how they would be constructed as an AST. It doesn't make sense for their interfaces to be separate. |