aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Guo <eric.guo@sandisk.com>2015-07-13 13:09:59 +0800
committerEric Guo <eric.guo@sandisk.com>2015-07-14 00:26:10 +0800
commit74563c63bdda08fdf1a026e908d51f536436c674 (patch)
tree06a17ec7a64a0f6d5c27bf2b75a3e32ae31162a7
parent14df08d80fc363fb9932d9534503b3276d30d9a5 (diff)
downloadrails-74563c63bdda08fdf1a026e908d51f536436c674.tar.gz
rails-74563c63bdda08fdf1a026e908d51f536436c674.tar.bz2
rails-74563c63bdda08fdf1a026e908d51f536436c674.zip
Follow up #370 for Oracle, to fix undefined method `expr' for 10:Fixnum bug.
-rw-r--r--lib/arel/visitors/oracle.rb2
-rw-r--r--test/visitors/test_oracle.rb4
2 files changed, 3 insertions, 3 deletions
diff --git a/lib/arel/visitors/oracle.rb b/lib/arel/visitors/oracle.rb
index ff9e38d050..875b0e5b6a 100644
--- a/lib/arel/visitors/oracle.rb
+++ b/lib/arel/visitors/oracle.rb
@@ -17,7 +17,7 @@ module Arel
if o.limit && o.offset
o = o.dup
- limit = o.limit.expr.expr
+ limit = o.limit.expr
offset = o.offset
o.offset = nil
collector << "
diff --git a/test/visitors/test_oracle.rb b/test/visitors/test_oracle.rb
index 41e77d93c0..e9ed9d76b3 100644
--- a/test/visitors/test_oracle.rb
+++ b/test/visitors/test_oracle.rb
@@ -111,7 +111,7 @@ module Arel
it 'creates a different subquery when there is an offset' do
stmt = Nodes::SelectStatement.new
- stmt.limit = Nodes::Limit.new(Nodes.build_quoted(10))
+ stmt.limit = Nodes::Limit.new(10)
stmt.offset = Nodes::Offset.new(10)
sql = compile stmt
sql.must_be_like %{
@@ -126,7 +126,7 @@ module Arel
it 'is idempotent with different subquery' do
stmt = Nodes::SelectStatement.new
- stmt.limit = Nodes::Limit.new(Nodes.build_quoted(10))
+ stmt.limit = Nodes::Limit.new(10)
stmt.offset = Nodes::Offset.new(10)
sql = compile stmt
sql2 = compile stmt