| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \ \ \
| |_|_|_|_|_|/
|/| | | | | | |
Add tests for ActiveRecord::Enum#enum when suffix specified
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | | |
Make name of attribute medium instead of normal
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove unused `require "thread"` in `test/cases/attribute_methods/read_test.rb`
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
`Mutex` was removed at 8eb7561ac6e8f020ec09608532de310c6b0b8dcd.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Remove duplicated `elsif` branch
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
The `elsif` branch is completely duplicated with `else` branch.
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Use :git for specifying dependencies from github with https protocol
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | | |
- This is required for bundler 1.13.0 because of which lot of specs are
failing on Travis CI.
- Similar to https://travis-ci.org/rails/rails/jobs/158905576#L559
|
|\ \ \ \
| | | | |
| | | | | |
use correct Gemfile in `bin/setup` test
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently, `bin/setup` test uses Gemfile of Rails. But this Gemfile is not a
file to be used in Rails application.
Add a Gemfile to Rails application that is created for test, it has been
modified to use the Gemfile.
|
|\ \ \ \
| | | | |
| | | | | |
Do not mutate AC::TestRequest::DEFAULT_OPTIONS
|
| |/ / / |
|
|\ \ \ \
| |/ / /
|/| | | |
Remove outdated "#TODO: Fix for binds." comment [ci skip]
|
|/ / /
| | |
| | |
| | | |
This comment was added at eaf5486 but already implemented.
|
|\ \ \
| |/ /
|/| | |
Pass `set_inverse_instance` block to `sc.execute` for `SingularAssociation`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Follow up to caa178c.
caa178c updated all code which sets inverse instances on newly loaded
associations to use block. But `SingularAssociation` was forgotten it.
|
|\ \ \
| | | |
| | | | |
Fix table name typos [ci skip]
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
update doc about default `cache_store` [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | | |
The default `cache_store` has changed in 8f0e0b6 to use `file_store`.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
call `.to_h` to avoid using deprecated method
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`ActionController::Parameters#merge` call `HashWithIndifferentAccess#merge`.
In addition, it calls `HashWithIndifferentAccess#update` from
`HashWithIndifferentAccess#merge`, where it is called the `#to_hash` of argument.
But `ActionController::Parameters#to_hash` is deprecated, warning message is
displayed.
To avoid this, modify to convert object to `Hash`.
Fixes #26415
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Clarify expires_now documentation
|
| | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] Simply formatting documents
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Revert " [ci skip] Remove duplicate example."
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
[ci skip] Remove duplicate example.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Selectively add `li ul, li ol { margin:0 1.5em; }` to subColl as needed
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Chapters column, instead of leaking to other lists.
Before:
https://monosnap.com/file/CNIMXcqv3HuRrObTNYWYFis8I3G8PT
After:
https://monosnap.com/file/0IyEKEy9hcRCIx82etR8ikinCo3vNb
Chapters column remains as is: http://take.ms/M0BkF
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Remove the word "mongrel" from documents [ci skip]
|
|/ / / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Currently mongrel is not maintained.
And it couldn't be built with any Ruby versions that
supported by Rails.
It is reasonable to remove the word "mongrel" in order to avoid
confusion from newcomer.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Fix Remaining Case-In-Assignment Statement Formatting
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Recently, the Rails team made an effort to keep the source code consistent, using Ruboco
(bb1ecdcc677bf6e68e0252505509c089619b5b90 and below). Some of the case
statements were missed.
This changes the case statements' formatting and is consistent with changes
in 810dff7c9fa9b2a38eb1560ce0378d760529ee6b and db63406cb007ab3756d2a96d2e0b5d4e777f8231.
|
|\ \ \ \ \ \ \ \ \
| |/ / / / / / / /
|/| | | | | | | | |
Minor grammar fix in engines.md [ci skip]
|
|/ / / / / / / / |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Remove redundant `!loaded?` condition
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Already checked `if !find_target? || loaded?`, unnecessary `!loaded?` in
elsif condition.
|
|\ \ \ \ \ \ \ \ \
| |/ / / / / / / /
|/| | | | | | | | |
Remove not used alias method
|
|/ / / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Bang methods of `AR::QueryMethods` are used only internally.
We only use `left_outer_joins!`, so we can remove this alias.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Move `require "models/post"` before `require "models/comment"`
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
"models/comment"`
to address BasicsTest#test_readonly_attributes failure #26368
It reproduces only when both of these conditions are satisfied:
- Other test files `autosave_association_test.rb` or `where_test.rb`
which executes `require "models/comment"` then `require "models/post"`
- When `autosave_association_test.rb` or `where_test.rb` executed before `base_test.rb`
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
use `descendants` to get class that inherited `ActiveJob::Base`
|
| |/ / / / / / / /
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
`subclasses` get only child classes.
Therefore, if create a job common parent class as `ApplicationJob`,
inherited class does not get properly.
|
|\ \ \ \ \ \ \ \ \
| |_|_|/ / / / / /
|/| | | | | | | | |
Remove unnecessary `query_scope`
|
| | | | | | | | | |
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
change `Class#descendants` to public API [ci skip]
|
|/ / / / / / / / /
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
`Class#descendants` has already been displayed in Rails guide,
so I think that may be displayed in doc.
http://guides.rubyonrails.org/active_support_core_extensions.html#descendants
|