| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Document that default_url_options must return a hash with symbolized keys
|
| |
| |
| |
| | |
keys
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing
changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a.
The reverted commit improved the performance in the wrong place, now we
have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement.
|
| |
| |
| |
| |
| |
| | |
user system total real
symbolize_keys 5.980000 0.070000 6.050000 ( 6.048187)
new_symbolize_keys 4.310000 0.050000 4.360000 ( 4.364745)
|
|/ |
|
|\
| |
| | |
Removes caching from ActiveRecord::Core::ClassMethods#relation
|
| |
| |
| |
| | |
(as described in #5667)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The #relation method gets called in four places and the return value was instantly cloned in three of them. The only place that did not clone was ActiveRecord::Scoping::Default::ClassMethods#unscoped. This introduced a bug described in #5667 and should really clone the relation, too. This means all four places would clone the relation, so it doesn't make a lot of sense caching it in the first place.
The four places with calls to relations are:
activerecord/lib/active_record/scoping/default.rb:110:in `block in build_default_scope'"
activerecord/lib/active_record/scoping/default.rb:42:in `unscoped'"
activerecord/lib/active_record/scoping/named.rb:38:in `scoped'"
activerecord/lib/active_record/scoping/named.rb:52:in `scope_attributes'"
|
| | |
|
|\ \
| | |
| | | |
Remove unnecessary in HTML 5 type attribute with default value
|
| | | |
|
|\ \ \
| | | |
| | | | |
url in comments - active_support/core_ext/integer/time.rb
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
active_support/core_ext/[integer|numeric]/time.rb
http://stdlib.rubyonrails.org/ last updated in 2005
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
romanvbabenko/refactor/rails_module_singleton_class_varibles
Class variables has been fixed to Singleton instance variables at Rails ...
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
use extract_options! in cycle helper
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The regexp used in titleize matches saxon genitive
and other contractions, only to call capitalize on
the captured text and have the apostrophe upcased
which yields the apostrophe itself. It is more
clear that the regexp matches just what it has to
match.
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \ |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
for reading/writing attributes"
This reverts commit a49fe6ec2cb9f22a3b18d7db5ae2ee90325e9d09.
Reason: The existing doc about using self[:attribute] is clear enough.
|
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit b11113f924d2eb2acbe836954d17a02163f45275.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
reading/writing attributes
Only write_attribute and read_attribute were documented and there was no mention to this alternative.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The previous example with just_raise_that_exception method
stopped working because MissingTranslation is not an instance of
Exception class any more, but has a +to_exception+ method.
Also the cleaner way is to re-raise only the desired exception, passing
everything else to the default ExceptionHandler.
Additionally this re-raising conflicts with Pluralization backend thus
we have to add a check that certain missing translation keys should
be ignored allowing the backend to fall back to the default
pluralization rule.
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
pass default value as argument to fetch
|
|/ / / / |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix url_for when options is nil
|
| | | | |
| | | | |
| | | | |
| | | | | |
stringified keys
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
RouteSet#url_for was modifying the options hash that belong to the
caller
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
carlosantoniodasilva/as-remove-require-and-warnings
Remove circular require from AS Deprecation, and fix warnings
|
| | | | |
|
|/ / / |
|
|\ \ \ |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit ddb987551357d30301ab8cd99f4580988fa83340.
Reason: The links must be relative so that they will work both in edge
and stable api sites.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
guide.
In particular, removed "pages that require to restrict access somehow" and shortened "Action Caching works like Page Caching except for the fact that the incoming web request does go from the webserver to the Rails stack and Action Pack so that before filters can be run on it before the cache is served".
|