Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Raise an error when query methods have blank arguments, and when blank ↵ | John J Wang | 2013-02-19 | 2 | -9/+34 |
| | | | | arguments are meaningless. | ||||
* | InvalidMessage is in ActiveSupport::MessageEncryptor namespace | Santiago Pastorino | 2013-02-19 | 2 | -4/+19 |
| | | | | Closes #9302 | ||||
* | Fix rake routes output in railties test | Carlos Antonio da Silva | 2013-02-19 | 1 | -2/+4 |
| | |||||
* | Fix AP tests related to routes inspector output and the new column titles | Carlos Antonio da Silva | 2013-02-19 | 1 | -20/+65 |
| | |||||
* | Add missing require to routes inspector | Carlos Antonio da Silva | 2013-02-19 | 1 | -0/+1 |
| | |||||
* | Merge pull request #9321 from mfilej/action-dispatch-http-url-requires | Xavier Noria | 2013-02-19 | 1 | -0/+3 |
|\ | | | | | Require ActiveSupport dependencies in ActionDispatch::Http::URL | ||||
| * | Require AS deps in ActionDispatch::Http::URL | Miha Filej | 2013-02-19 | 1 | -0/+3 |
| | | | | | | | | Allows us to use url_for and friends in isolation. | ||||
* | | Remove config.autoload_paths from config/application.rb | Andrew White | 2013-02-19 | 1 | -3/+0 |
| | | | | | | | | | | | | | | | | | | | | Most application developers shouldn't be adding paths to `config.autoload_paths` as it won't be eagerly loaded so remove it from the generated config/application.rb file. If a developer does want to autoload from paths outside of the app directory then they should add the path to `config.eager_load_paths` as these paths are also autoloaded as well. | ||||
* | | Don't unhook autoloading in production | Andrew White | 2013-02-19 | 1 | -7/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Whilst autoloading is known to be not threadsafe, leaving it in place is a softer solution than failing hard when an application is deployed. Many older applications will have paths added to `autoload_paths` and ideally these should be eagerly loaded to be threadsafe. However one of these paths is quite often lib which could lead to unintended consequences due to the 'junk drawer' nature of this directory. Developers should refrain from adding paths to `autoload_paths` or `eager_load_paths` and use custom folders inside app for code that needs to be eagerly loaded and use `require` or `require_dependency` to explicitly load code from other locations. | ||||
* | | Revert "Deprecate the `eager_load_paths` configuration" | Andrew White | 2013-02-19 | 7 | -91/+66 |
|/ | | | | | | | | | | | Because of the possibility of lib being unintentionally eager loaded it's been agreed that we'll leave autoload paths and eager load paths separate for Rails 4.0. This reverts commit 0757b3388ffe4f44b60de950d40e18ef05055931. Conflicts: railties/CHANGELOG.md | ||||
* | Duck typing is hard. Add header to HtmlTableFormatter. | Steve Klabnik | 2013-02-18 | 1 | -0/+4 |
| | | | | | | | Somehow I missed this method, which was then throwing an error when viewing routes as HTML. Make @rubys happy: ✔ | ||||
* | editorial tweaks | Xavier Noria | 2013-02-19 | 2 | -4/+7 |
| | |||||
* | Use strip_heredoc in the tests as well. | Steve Klabnik | 2013-02-18 | 1 | -5/+6 |
| | | | | Thanks @sikachu. :sweat_smile: | ||||
* | use strip_heredoc to keep indentation consistent. | Steve Klabnik | 2013-02-18 | 1 | -12/+12 |
| | | | | Thanks @sikachu. :heart: | ||||
* | Merge pull request #9316 from steveklabnik/no_routes | Xavier Noria | 2013-02-18 | 3 | -0/+46 |
|\ | | | | | Print message on stderr when no routes are defined. | ||||
| * | Add message when you have no routes defined. | Steve Klabnik | 2013-02-18 | 3 | -0/+46 |
|/ | | | | | | Print a message in both `rake routes` and at GET "/rails/info/routes" that lets you know you have no routes defined, as well as linking to the Rails Guide on the topic. | ||||
* | Merge pull request #9318 from steveklabnik/router_headings | Xavier Noria | 2013-02-18 | 1 | -3/+19 |
|\ | | | | | Add headings to rake routes table | ||||
| * | Add headings to rake routes table | Steve Klabnik | 2013-02-18 | 1 | -3/+19 |
| | | |||||
* | | Merge pull request #9317 from balexand/patch-1 | Rafael Mendonça França | 2013-02-18 | 1 | -0/+1 |
|\ \ | |/ |/| | Document changes from #7968 in Upgrading Guide | ||||
| * | Document changes in #7968 | Brian Alexander | 2013-02-18 | 1 | -0/+1 |
|/ | |||||
* | Bump up minitest dependency and remove our own reinvented version of ↵ | Akira Matsuda | 2013-02-19 | 2 | -38/+2 |
| | | | | ParallelEach | ||||
* | Gist URLs are now namespaced | Akira Matsuda | 2013-02-18 | 6 | -11/+11 |
| | | | | see: https://github.com/blog/1406-namespaced-gists | ||||
* | Merge pull request #9313 from bkzl/return-false-on-toggle-on-error-pages | Guillermo Iguaran | 2013-02-17 | 2 | -6/+7 |
|\ | | | | | Return false in toggle function on error pages | ||||
| * | Return false on toggle on error pages | Bartlomiej Kozal | 2013-02-17 | 2 | -6/+7 |
| | | |||||
* | | Merge pull request #9312 from Takehiro-Adachi/add_tests_for_ar_create | Guillermo Iguaran | 2013-02-17 | 1 | -0/+8 |
|\ \ | |/ |/| | Add test for ActiveRecord::Base#create | ||||
| * | add tests for ActiveRecord::Base#create | Takehiro Adachi | 2013-02-18 | 1 | -0/+8 |
|/ | |||||
* | Add CHANGELOG entry for 41ff6a10216f48f43605a1f9cd6094765cab750f | Andrew White | 2013-02-17 | 1 | -0/+40 |
| | | | | [ci skip] | ||||
* | Merge pull request #9307 from wangjohn/remove_unneeded_md5_digest | Xavier Noria | 2013-02-16 | 1 | -1/+0 |
|\ | | | | | Removed an old require of an MD5 digest which is no longer used. | ||||
| * | Removed an old require of an MD5 digest which is no longer used. | wangjohn | 2013-02-15 | 1 | -1/+0 |
| | | |||||
* | | copy-edits RDoc in fba496f | Xavier Noria | 2013-02-16 | 1 | -4/+4 |
| | | | | | | | | | | | | | | This revision makes the terminology uniform with the rest of the file. In general we describe these methods in terms of the adapter, rather than the database. (As a side note, if we wanted to refer to the database we would write "PostgreSQL".) | ||||
* | | Remove valid_type? method | Jon Leighton | 2013-02-15 | 4 | -17/+0 |
| | | | | | | | | | | It was supposed to be removed by the preceding two reversions but I did them in the wrong order. | ||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-02-15 | 11 | -9/+68 |
|\ \ | | | | | | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md | ||||
| * | | copy edits [ci skip] | Vijay Dev | 2013-02-15 | 2 | -3/+3 |
| | | | |||||
| * | | Revert "incorrect content of models/comment.rb after 'rails generate'" | Rafael Mendonça França | 2013-02-13 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | | | | | | This reverts commit 0f0803fda5df60319d8646bb4f3e71f2e596316a. Reason: The content was correct since attr_accessible was removed from rails master. | ||||
| * | | incorrect content of models/comment.rb after 'rails generate' | Kuba Brecka | 2013-02-13 | 1 | -0/+2 |
| | | | |||||
| * | | Correct bullet content line wrapping | Tim "Roger" Harvey | 2013-02-12 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | The `:prefix` bullet content was not properly wrapping, dropping to the following line because the additional content was not indented properly. With this change, it will now display properly the way `:discard_type` does. | ||||
| * | | Detail Ruby 1.8 ships with TestUnit and Ruby 1.9 with MiniTest | Americo Savinon | 2013-02-12 | 1 | -1/+4 |
| | | | |||||
| * | | Fix typo. | Carson McDonald | 2013-02-11 | 1 | -1/+1 |
| | | | | | | | | | | | | [ci skip] | ||||
| * | | Fix supported ruby version for Rails 4 | Ryunosuke SATO | 2013-02-10 | 1 | -1/+1 |
| | | | |||||
| * | | Fix CoffeeScript example | Ryunosuke SATO | 2013-02-10 | 1 | -1/+1 |
| | | | | | | | | | | | | `a[data-color]` is not used in example html. | ||||
| * | | Clarify ActiveModel::Validator initialization in docs. | Henrik Nyh | 2013-02-09 | 1 | -0/+3 |
| | | | | | | | | | As discussed with @josevalim on Ruby Rogues Parley. | ||||
| * | | Validations guide: validates_with init clarification. | Henrik Nyh | 2013-02-09 | 1 | -0/+29 |
| | | | | | | | | | As discussed with @josevalim on Ruby Rogues Parley. | ||||
| * | | Add example for ActiveRecord::Base.joins using a string as argument | Maurizio De Santis | 2013-02-07 | 1 | -0/+5 |
| | | | |||||
| * | | Add example for ActiveRecord::Base.group using a string as argument | Maurizio De Santis | 2013-02-07 | 1 | -0/+3 |
| | | | |||||
| * | | Add documentation for ActiveRecord.select when use strings as arguments | Maurizio De Santis | 2013-02-07 | 1 | -0/+10 |
| | | | |||||
| * | | Add ActiveRecord.count documentation when used on group relations | Maurizio De Santis | 2013-02-07 | 1 | -0/+6 |
| | | | |||||
| * | | Change Class#subclasses doc example | Dalibor Nasevic | 2013-02-06 | 1 | -2/+2 |
| | | | |||||
| * | | Fixing the examples for button_to | Marc Baumbach | 2013-02-06 | 1 | -2/+2 |
| | | | | | | | | | The examples do not generate the output they intend to due to not explicitly declaring the hash separations. This causes it to be treated as one parameter instead of the intended two parameters. | ||||
| * | | Fix file name in document [ci skip] | Ryunosuke SATO | 2013-02-05 | 1 | -1/+1 |
| | | | | | | | | | | | | This file was renamed in c8a25386d. | ||||
* | | | Revert "Make valid_type? public" | Jon Leighton | 2013-02-15 | 4 | -12/+17 |
| | | | | | | | | | | | | | | | | | | This reverts commit 5d528f835e871f5f9d4b68e8a81cfbe900b7e718. Relates to f8c8ad5 which is also getting reverted due to failing test. |