diff options
| author | Akira Matsuda <ronnie@dio.jp> | 2013-02-19 00:08:16 +0900 |
|---|---|---|
| committer | Akira Matsuda <ronnie@dio.jp> | 2013-02-19 00:08:16 +0900 |
| commit | 18c57c79ef7728aeb7f5a13f9136958a0d62ee1b (patch) | |
| tree | 641430f11bc7a6ef62de346fe4283b444197f9e8 | |
| parent | 57b0ae8011ab0502253631bd6fdbc0fc838b593e (diff) | |
| download | rails-18c57c79ef7728aeb7f5a13f9136958a0d62ee1b.tar.gz rails-18c57c79ef7728aeb7f5a13f9136958a0d62ee1b.tar.bz2 rails-18c57c79ef7728aeb7f5a13f9136958a0d62ee1b.zip | |
Bump up minitest dependency and remove our own reinvented version of ParallelEach
| -rw-r--r-- | activesupport/activesupport.gemspec | 2 | ||||
| -rw-r--r-- | activesupport/lib/active_support/testing/isolation.rb | 38 |
2 files changed, 2 insertions, 38 deletions
diff --git a/activesupport/activesupport.gemspec b/activesupport/activesupport.gemspec index 4c9e59dbd2..64b23996e8 100644 --- a/activesupport/activesupport.gemspec +++ b/activesupport/activesupport.gemspec @@ -23,6 +23,6 @@ Gem::Specification.new do |s| s.add_dependency 'i18n', '~> 0.6' s.add_dependency 'multi_json', '~> 1.3' s.add_dependency 'tzinfo', '~> 0.3.33' - s.add_dependency 'minitest', '~> 4.1' + s.add_dependency 'minitest', '~> 4.2' s.add_dependency 'thread_safe','~> 0.1' end diff --git a/activesupport/lib/active_support/testing/isolation.rb b/activesupport/lib/active_support/testing/isolation.rb index dca91e8b75..d70d971538 100644 --- a/activesupport/lib/active_support/testing/isolation.rb +++ b/activesupport/lib/active_support/testing/isolation.rb @@ -1,8 +1,5 @@ require 'rbconfig' -begin - require 'minitest/parallel_each' -rescue LoadError -end +require 'minitest/parallel_each' module ActiveSupport module Testing @@ -48,39 +45,6 @@ module ActiveSupport module Isolation require 'thread' - # Recent versions of MiniTest (such as the one shipped with Ruby 2.0) already define - # a ParallelEach class. - unless defined? ParallelEach - class ParallelEach - include Enumerable - - # default to 2 cores - CORES = (ENV['TEST_CORES'] || 2).to_i - - def initialize list - @list = list - @queue = SizedQueue.new CORES - end - - def grep pattern - self.class.new super - end - - def each - threads = CORES.times.map { - Thread.new { - while job = @queue.pop - yield job - end - } - } - @list.each { |i| @queue << i } - CORES.times { @queue << nil } - threads.each(&:join) - end - end - end - def self.included(klass) #:nodoc: klass.extend(Module.new { def test_methods |