Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #9120 from hone/db_migrate_with_database_url | Rafael Mendonça França | 2013-02-20 | 5 | -10/+24 |
|\ | | | | | fix rake db:migrate when used with ENV['DATABASE_URL'] | ||||
| * | update changelog | Terence Lee | 2013-02-21 | 1 | -0/+3 |
| | | |||||
| * | run the load_structure test in the test environment | Terence Lee | 2013-02-21 | 1 | -3/+10 |
| | | |||||
| * | test DATABASE_URL without database.yml around | Terence Lee | 2013-02-21 | 1 | -0/+2 |
| | | |||||
| * | standardize database_configuration to a hash | Terence Lee | 2013-02-21 | 3 | -7/+9 |
|/ | | | | | | | make connection_url_to_hash a class method This als prevents loading database.yml if it doesn't exist but DATABASE_URL does | ||||
* | Merge pull request #9328 from sikachu/ps-remove-xml-parser | Guillermo Iguaran | 2013-02-20 | 5 | -342/+31 |
|\ | | | | | Remove XML Parser from ActionDispatch | ||||
| * | Remove XML Parser from ActionDispatch | Prem Sichanugrist | 2013-02-20 | 5 | -342/+31 |
|/ | | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem. | ||||
* | Whitespace :heart: and hash syntax change | Rafael Mendonça França | 2013-02-20 | 1 | -23/+22 |
| | |||||
* | Merge pull request #8060 from ↵ | Xavier Noria | 2013-02-20 | 3 | -3/+20 |
|\ | | | | | | | | | senny/7313_descriptive_error_message_for_missing_adapter descriptive error message when AR adapter was not found. Closes #7313 | ||||
| * | descriptive error message when AR adapter was not found. Closes #7313. | Yves Senn | 2013-02-20 | 3 | -3/+20 |
|/ | |||||
* | Merge pull request #9330 from bdmac/time_zone_select_dup | Andrew White | 2013-02-19 | 3 | -1/+16 |
|\ | | | | | Fix time_zone_options_for_select to not mutate TimeZones array | ||||
| * | Fix time_zone_options_for_select to not mutate TimeZones array | Brian McManus | 2013-02-19 | 3 | -1/+16 |
| | | | | | | | | | | | | | | | | | | | | Previous implementation of time_zone_options_for_select did not dup the ActiveSupport::TimeZone.all array. When :priority_zones were provided the method would reject! the zones from the memoized TimeZones array thus affecting future requests to the server. Essentially whatever zones were specified as :priority_zones would show up for the first request but then disappear from the time zone options on future requests. | ||||
* | | Merge pull request #9331 from robertomiranda/upgrading-guide | Guillermo Iguaran | 2013-02-19 | 1 | -0/+10 |
|\ \ | |/ |/| | Improve upgrading guide with ActionDispatch::BestStandardsSupport remova... | ||||
| * | Improve upgrading guide with ActionDispatch::BestStandardsSupport removal | robertomiranda | 2013-02-19 | 1 | -0/+10 |
|/ | |||||
* | Better not use tab chars in the generator template | Akira Matsuda | 2013-02-20 | 1 | -5/+5 |
| | |||||
* | Merge pull request #9324 from acapilleri/add_on_empty | Steve Klabnik | 2013-02-19 | 1 | -0/+7 |
|\ | | | | | added more accurate test for add_on_empty | ||||
| * | added more accurate test for add_on_empty | Angelo capilleri | 2013-02-19 | 1 | -0/+7 |
| | | | | | | | | | | with the current tests, if delete the assignment of is_empty in add_on_empty method the tests not fail. With this test, if we delete is_empty, the test fails | ||||
* | | s/revertible/reversible/ | Xavier Noria | 2013-02-19 | 1 | -1/+1 |
| | | |||||
* | | fixes a typo in the migrations guide | Xavier Noria | 2013-02-19 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #9315 from ↵ | Steve Klabnik | 2013-02-19 | 1 | -23/+0 |
|\ \ | |/ |/| | | | | | Takehiro-Adachi/remove-unecessary-tests-from-ar-base_testrb delete duplicated tests in AR base_test.rb | ||||
| * | delete duplicated tests in AR base_test.rb | Takehiro Adachi | 2013-02-19 | 1 | -23/+0 |
| | | | | | | | | These are duplicated with the tests which are in relations_test.rb | ||||
* | | moves a CHANGELOG entry from AR to AP | Xavier Noria | 2013-02-19 | 2 | -4/+4 |
| | | |||||
* | | small tweaks in the AR CHANGELOG | Xavier Noria | 2013-02-19 | 1 | -4/+4 |
| | | |||||
* | | Merge pull request #9258 from wangjohn/blank_argument_errors_in_arel | Rafael Mendonça França | 2013-02-19 | 2 | -9/+34 |
|\ \ | | | | | | | Raising an error when query methods have blank arguments. | ||||
| * | | Raise an error when query methods have blank arguments, and when blank ↵ | John J Wang | 2013-02-19 | 2 | -9/+34 |
|/ / | | | | | | | arguments are meaningless. | ||||
* | | InvalidMessage is in ActiveSupport::MessageEncryptor namespace | Santiago Pastorino | 2013-02-19 | 2 | -4/+19 |
| | | | | | | | | Closes #9302 | ||||
* | | Fix rake routes output in railties test | Carlos Antonio da Silva | 2013-02-19 | 1 | -2/+4 |
| | | |||||
* | | Fix AP tests related to routes inspector output and the new column titles | Carlos Antonio da Silva | 2013-02-19 | 1 | -20/+65 |
| | | |||||
* | | Add missing require to routes inspector | Carlos Antonio da Silva | 2013-02-19 | 1 | -0/+1 |
| | | |||||
* | | Merge pull request #9321 from mfilej/action-dispatch-http-url-requires | Xavier Noria | 2013-02-19 | 1 | -0/+3 |
|\ \ | | | | | | | Require ActiveSupport dependencies in ActionDispatch::Http::URL | ||||
| * | | Require AS deps in ActionDispatch::Http::URL | Miha Filej | 2013-02-19 | 1 | -0/+3 |
| | | | | | | | | | | | | Allows us to use url_for and friends in isolation. | ||||
* | | | Remove config.autoload_paths from config/application.rb | Andrew White | 2013-02-19 | 1 | -3/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most application developers shouldn't be adding paths to `config.autoload_paths` as it won't be eagerly loaded so remove it from the generated config/application.rb file. If a developer does want to autoload from paths outside of the app directory then they should add the path to `config.eager_load_paths` as these paths are also autoloaded as well. | ||||
* | | | Don't unhook autoloading in production | Andrew White | 2013-02-19 | 1 | -7/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Whilst autoloading is known to be not threadsafe, leaving it in place is a softer solution than failing hard when an application is deployed. Many older applications will have paths added to `autoload_paths` and ideally these should be eagerly loaded to be threadsafe. However one of these paths is quite often lib which could lead to unintended consequences due to the 'junk drawer' nature of this directory. Developers should refrain from adding paths to `autoload_paths` or `eager_load_paths` and use custom folders inside app for code that needs to be eagerly loaded and use `require` or `require_dependency` to explicitly load code from other locations. | ||||
* | | | Revert "Deprecate the `eager_load_paths` configuration" | Andrew White | 2013-02-19 | 7 | -91/+66 |
|/ / | | | | | | | | | | | | | | | | | | | | | Because of the possibility of lib being unintentionally eager loaded it's been agreed that we'll leave autoload paths and eager load paths separate for Rails 4.0. This reverts commit 0757b3388ffe4f44b60de950d40e18ef05055931. Conflicts: railties/CHANGELOG.md | ||||
* | | Duck typing is hard. Add header to HtmlTableFormatter. | Steve Klabnik | 2013-02-18 | 1 | -0/+4 |
| | | | | | | | | | | | | | | Somehow I missed this method, which was then throwing an error when viewing routes as HTML. Make @rubys happy: ✔ | ||||
* | | editorial tweaks | Xavier Noria | 2013-02-19 | 2 | -4/+7 |
| | | |||||
* | | Use strip_heredoc in the tests as well. | Steve Klabnik | 2013-02-18 | 1 | -5/+6 |
| | | | | | | | | Thanks @sikachu. :sweat_smile: | ||||
* | | use strip_heredoc to keep indentation consistent. | Steve Klabnik | 2013-02-18 | 1 | -12/+12 |
| | | | | | | | | Thanks @sikachu. :heart: | ||||
* | | Merge pull request #9316 from steveklabnik/no_routes | Xavier Noria | 2013-02-18 | 3 | -0/+46 |
|\ \ | | | | | | | Print message on stderr when no routes are defined. | ||||
| * | | Add message when you have no routes defined. | Steve Klabnik | 2013-02-18 | 3 | -0/+46 |
|/ / | | | | | | | | | | | Print a message in both `rake routes` and at GET "/rails/info/routes" that lets you know you have no routes defined, as well as linking to the Rails Guide on the topic. | ||||
* | | Merge pull request #9318 from steveklabnik/router_headings | Xavier Noria | 2013-02-18 | 1 | -3/+19 |
|\ \ | | | | | | | Add headings to rake routes table | ||||
| * | | Add headings to rake routes table | Steve Klabnik | 2013-02-18 | 1 | -3/+19 |
| | | | |||||
* | | | Merge pull request #9317 from balexand/patch-1 | Rafael Mendonça França | 2013-02-18 | 1 | -0/+1 |
|\ \ \ | |/ / |/| | | Document changes from #7968 in Upgrading Guide | ||||
| * | | Document changes in #7968 | Brian Alexander | 2013-02-18 | 1 | -0/+1 |
|/ / | |||||
* | | Bump up minitest dependency and remove our own reinvented version of ↵ | Akira Matsuda | 2013-02-19 | 2 | -38/+2 |
| | | | | | | | | ParallelEach | ||||
* | | Gist URLs are now namespaced | Akira Matsuda | 2013-02-18 | 6 | -11/+11 |
|/ | | | | see: https://github.com/blog/1406-namespaced-gists | ||||
* | Merge pull request #9313 from bkzl/return-false-on-toggle-on-error-pages | Guillermo Iguaran | 2013-02-17 | 2 | -6/+7 |
|\ | | | | | Return false in toggle function on error pages | ||||
| * | Return false on toggle on error pages | Bartlomiej Kozal | 2013-02-17 | 2 | -6/+7 |
| | | |||||
* | | Merge pull request #9312 from Takehiro-Adachi/add_tests_for_ar_create | Guillermo Iguaran | 2013-02-17 | 1 | -0/+8 |
|\ \ | |/ |/| | Add test for ActiveRecord::Base#create | ||||
| * | add tests for ActiveRecord::Base#create | Takehiro Adachi | 2013-02-18 | 1 | -0/+8 |
|/ |