aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Re-use the predicate builder in the `ArrayHandler`Sean Griffin2014-12-262-8/+16
| | | | | | | | | | This reduces the number of places which will need to care about single value or range specific logic as we introduce type casting. The array handler is only responsible for producing `in` statements. /cc @mrgilman [Sean Griffin & Melanie Gilman]
* Change `PredicateBuilder` handler methods to instance methodsSean Griffin2014-12-266-31/+74
| | | | | | | | | | | | This will allow us to pass the predicate builder into the constructor of these handlers. The procs had to be changed to objects, because the `PredicateBuilder` needs to be marshalable. If we ever decide to make `register_handler` part of the public API, we should come up with a better solution which allows procs. /cc @mrgilman [Sean Griffin & Melanie Gilman]
* Add missing `:nodoc:`Sean Griffin2014-12-261-1/+1
| | | | | We're accidentally documenting `PredicateBuilder` and `ArrayHandler` since there's a constant which is missing `# :nodoc:`
* Inject the `PredicateBuilder` into the `Relation` instanceSean Griffin2014-12-2612-43/+52
| | | | | | | Construction of relations can be a hotspot, we don't want to create one of these in the constructor. This also allows us to do more expensive things in the predicate builder's constructor, since it's created once per AR::Base subclass
* Remove unused `@relation` instance variableSean Griffin2014-12-261-2/+0
| | | | We don't memoize the relation instance
* Merge branch 'brainopia-remember_frozen_state_in_transaction'Sean Griffin2014-12-262-7/+20
|\
| * Propagate frozen state during transaction changesbrainopia2014-12-262-7/+19
|/
* Correctly ignore `case_sensitive` for UUID uniqueness validationSean Griffin2014-12-266-2/+31
| | | | | | | | I think we should deprecate this behavior and just error if you tell us to do a case insensitive comparison for types which are not case sensitive. Partially reverts 35592307 Fixes #18195
* Update guides regarding the extension changesRobin Dupret2014-12-263-18/+18
| | | | | | | | | | With rails/coffee-rails#61 (and #17241), the `.coffee` extension is favoured over `.js.coffee`. Respectively, with rails/sass-rails#271 `.scss` and `.sass` are favoured over `.css.scss` and `.css.sass`. Let's update the documentation to reflect that. [ci skip]
* Merge pull request #18206 from ↵Yves Senn2014-12-263-1/+11
|\ | | | | | | | | kamipo/dump_default_nil_for_postgresql_uuid_primary_key Dump the default `nil` for PostgreSQL UUID primary key.
| * Dump the default `nil` for PostgreSQL UUID primary key.Ryuta Kamizono2014-12-263-1/+11
|/
* Merge pull request #18205 from vipulnsward/fix-railties-warningGuillermo Iguaran2014-12-261-3/+3
|\ | | | | Fixed warning `possible reference to past scope` from railties
| * - Changed `paths` to `routing_paths` to avoid warning `possible reference to ↵Vipul A M2014-12-261-3/+3
|/ | | | past scope`
* Merge pull request #18197 from vipulnsward/fix-ar-2-2warningGuillermo Iguaran2014-12-261-2/+2
|\ | | | | Fixed AR warning on ruby 2.2
| * - Changed `target` to `target_reflection` to avoid warning `possible ↵Vipul A M2014-12-251-2/+2
| | | | | | | | reference to past scope`
* | Merge pull request #18203 from kyledecot/ruby-2.2Guillermo Iguaran2014-12-261-1/+1
|\ \ | | | | | | Targeting 2.2
| * | targeting 2.2Kyle Decot2014-12-251-1/+1
| | |
* | | Merge pull request #18204 from chocoby/remove-double-spaceGuillermo Iguaran2014-12-261-1/+1
|\ \ \ | | | | | | | | Remove unnecessary double space
| * | | Remove unnecessary double spaceKenta Okamoto2014-12-261-1/+1
| |/ /
* | | Merge pull request #18194 from claudiob/remove-action-controller-model-namingGuillermo Iguaran2014-12-252-16/+0
|\ \ \ | |/ / |/| | Remove ActionController::ModelNaming
| * | Remove ActionController::ModelNamingclaudiob2014-12-252-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The methods in these modules are not used anywhere. They used to be invoked in polymorphic_routes.rb but their usage was removed in e821045. What is your opinion about removing these methods? They do belong to the public API, but in reality their code has already been duplicated to ActionView::ModelNaming, since they are used by methods like `dom_id` and `dom_class` to associated records with DOM elements (in ActionView). Please tell me if you think that removing this module is a good idea and, in that case, if the PR is okay as it is, or you'd rather start by showing a deprecation message, and remove the module in Rails 5.1.
* | | Add example to get Errored test to pass in Testing guide [ci skip]Zachary Scott2014-12-251-0/+13
| |/ |/|
* | Merge pull request #18196 from PavelPenkov/rails_env_instead_of_railsMatthew Draper2014-12-261-1/+1
|\ \ | |/ |/| Check for Rails.env instead of Rails
| * Check for Rails.env instead of RailsPavel Penkov2014-12-251-1/+1
|/ | | | | `Rails` constant is added by rails-html-sanitizer leading to bugs in non-Rails apps using ActiveRecord and ActionMailer
* Merge pull request #18185 from ivalkeen/add_missing_guidesZachary Scott2014-12-241-0/+5
|\ | | | | List the Active Support Instrumentation guide in the index (as WIP)
| * List the Active Support Instrumentation guide in the index (as WIP)Ivan Tkalin2014-12-241-0/+5
| |
* | Correct grammar to fix #18182 [ci skip]Zachary Scott2014-12-241-1/+1
| |
* | Merge pull request #18190 from ef718/masterZachary Scott2014-12-241-1/+1
|\ \ | | | | | | Fix grammar in Caching with Rails docs
| * | Update grammar [ci skip]Elaine Fang2014-12-241-1/+1
| |/
* / Fix a few typos [ci skip]Robin Dupret2014-12-242-5/+6
|/
* Merge pull request #18183 from danbernier/masterArun Agrawal2014-12-241-1/+1
|\ | | | | Fix bug in ActionMailer guide.
| * Fix bug in ActionMailer guide.Dan Bernier2014-12-241-1/+1
|/ | | | | When setting a mailer's default from address, you have to pass a hash with a `:from` key; you can't pass just an email address.
* Merge pull request #18107 from mkdynamic/add-reply-to-mail-toSean Griffin2014-12-242-4/+5
|\ | | | | Add support for Reply-To field in mail_to helper
| * Add support for Reply-To field in mail_to helperMark Dodwell2014-12-202-4/+5
| |
* | Merge pull request #18180 from vipulnsward/remove-unnecessary-name-passingSean Griffin2014-12-241-4/+4
|\ \ | | | | | | Removed unused parameter to cookie serialize method
| * | - Removed unused parameter to cookie serialize method and fixed usage of the ↵Vipul A M2014-12-241-4/+4
|/ / | | | | | | same elsewhere
* | Merge pull request #18159 from ↵Sean Griffin2014-12-231-1/+1
|\ \ | | | | | | | | | | | | M7/docs-active_record-update_query_method_docs_with_full_description Describe full behaviour of Active Record's attribute query methods
| * | Clarify that query methods have a custom definition of whether a numeric ↵Michael D.W. Prendergast2014-12-231-2/+2
| | | | | | | | | | | | | | | value is present. [ci skip] The way Active Record query methods handle numeric values is a special case, and is not part of Rails's standard definition of present. This update attempts to make this more clear in the docs, so that people don't expect Object#present? to return false if used on a number that is zero.
| * | Clarify that the word present refers to Object#present?. [ci skip]Michael D.W. Prendergast2014-12-231-36/+2
| | | | | | | | | Update Active Record's attribute query methods documentation to clarify that whether an attribute is present is based on Object#present?. This gives people a place to go see what the exact definition of presence is. [ci skip]
| * | Update Active Record's attribute query methods documentation to describe its ↵Michael D.W. Prendergast2014-12-221-2/+36
| | | | | | | | | | | | full behaviour. [ci skip]
* | | removes superfluous regexp groupXavier Noria2014-12-231-1/+1
| | |
* | | warn about reading guides in GitHubXavier Noria2014-12-2348-0/+96
| | | | | | | | | | | | References #18148.
* | | third test to warn against reading guides in GitHubXavier Noria2014-12-232-2/+2
| | |
* | | second test to warn against reading guides in GitHubXavier Noria2014-12-232-3/+2
| | |
* | | proof of concept, need to check in GitHubXavier Noria2014-12-232-0/+4
| | |
* | | Merge pull request #18174 from bogdan/cleanup_has_many_though_association_countSean Griffin2014-12-231-15/+0
|\ \ \ | | | | | | | | Remove unneeded special case to calculate size for has_many :through
| * | | Remove unneeded special case to calculate size for has_many :throughBogdan Gusiev2014-12-231-15/+0
| | | | | | | | | | | | | | | | | | | | All cases are properly handled in CollectionAssociation for all subclasses of this association
* | | | Merge pull request #18170 from tgxworld/add_docs_for_rails_application_secretsSean Griffin2014-12-231-1/+15
|\ \ \ \ | | | | | | | | | | | | | | | [ci skip]
| * | | | Rails::Application#secrets should be documented.Guo Xiang Tan2014-12-241-1/+15
| | | | |
* | | | | Don't treat `nil` as changed in serialized typesSean Griffin2014-12-232-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were ignoring the `default_value?` escape clause in the serialized type, which caused the default value to always be treated as changed. Fixes #18169
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 21:18:23 +0000