diff options
| author | claudiob <claudiob@gmail.com> | 2014-12-19 12:49:50 -0800 |
|---|---|---|
| committer | claudiob <claudiob@gmail.com> | 2014-12-25 00:30:46 +0100 |
| commit | 4761d81923fd9f5a39fb1fa051cbbad2b52c9615 (patch) | |
| tree | bc3808f5ec75de8af06e660f24b885747e2c6847 | |
| parent | a2059068c02c25e61cc7d5701b0bbd2913e4012f (diff) | |
| download | rails-4761d81923fd9f5a39fb1fa051cbbad2b52c9615.tar.gz rails-4761d81923fd9f5a39fb1fa051cbbad2b52c9615.tar.bz2 rails-4761d81923fd9f5a39fb1fa051cbbad2b52c9615.zip | |
Remove ActionController::ModelNaming
The methods in these modules are not used anywhere. They used to be
invoked in polymorphic_routes.rb but their usage was removed in e821045.
What is your opinion about removing these methods?
They do belong to the public API, but in reality their code has already been duplicated to ActionView::ModelNaming, since they are used by methods like `dom_id` and `dom_class` to associated records with DOM elements (in
ActionView).
Please tell me if you think that removing this module is a good idea and,
in that case, if the PR is okay as it is, or you'd rather start by showing
a deprecation message, and remove the module in Rails 5.1.
| -rw-r--r-- | actionpack/lib/action_controller/model_naming.rb | 12 | ||||
| -rw-r--r-- | actionpack/lib/action_dispatch/routing/polymorphic_routes.rb | 4 |
2 files changed, 0 insertions, 16 deletions
diff --git a/actionpack/lib/action_controller/model_naming.rb b/actionpack/lib/action_controller/model_naming.rb deleted file mode 100644 index 2b33f67263..0000000000 --- a/actionpack/lib/action_controller/model_naming.rb +++ /dev/null @@ -1,12 +0,0 @@ -module ActionController - module ModelNaming - # Converts the given object to an ActiveModel compliant one. - def convert_to_model(object) - object.respond_to?(:to_model) ? object.to_model : object - end - - def model_name_from_record_or_class(record_or_class) - convert_to_model(record_or_class).model_name - end - end -end diff --git a/actionpack/lib/action_dispatch/routing/polymorphic_routes.rb b/actionpack/lib/action_dispatch/routing/polymorphic_routes.rb index 0847842fa2..d9bd277d62 100644 --- a/actionpack/lib/action_dispatch/routing/polymorphic_routes.rb +++ b/actionpack/lib/action_dispatch/routing/polymorphic_routes.rb @@ -1,5 +1,3 @@ -require 'action_controller/model_naming' - module ActionDispatch module Routing # Polymorphic URL helpers are methods for smart resolution to a named route call when @@ -55,8 +53,6 @@ module ActionDispatch # form_for([blog, @post]) # => "/blog/posts/1" # module PolymorphicRoutes - include ActionController::ModelNaming - # Constructs a call to a named RESTful route for the given record and returns the # resulting URL string. For example: # |