aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | | | Add git_source to Gemfile for plugin generatorYoshiyuki Hirano2017-08-093-0/+10
| | |_|/ / / / / / / / | |/| | | | | | | | |
* | | | | | | | | | | Merge pull request #30060 from bdewater/aj-callback-docsRafael França2017-08-111-22/+30
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Improve callback examples in Active Job guide
| * | | | | | | | | | | Make one line example fit on one line [ci skip]Bart de Water2017-08-091-3/+1
| | | | | | | | | | | |
| * | | | | | | | | | | Improve callback examples in Active Job guide [ci skip]Bart de Water2017-08-031-22/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The advice for symbol/block form is taken from the Active Record guides.
* | | | | | | | | | | | Merge pull request #30159 from allcentury/dump-temp-file-permissionsRafael França2017-08-111-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Use copy to preserve file permissions
| * | | | | | | | | | | | Use copy to preserve file permissionsAnthony Ross2017-08-091-1/+1
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #30092 from bogdanvlviv/prevent-generation-extra-empty-linesRafael França2017-08-112-7/+6
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevent generation extra empty lines in a plugin's Rakefile
| * | | | | | | | | | | | | Prevent generation extra empty lines in a plugin's Rakefilebogdanvlviv2017-08-092-7/+6
| | |_|_|_|_|/ / / / / / / | |/| | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #30147 from yhirano55/fix_trailing_blank_linesRafael França2017-08-112-2/+0
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines`
| * | | | | | | | | | | | | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines`Yoshiyuki Hirano2017-08-093-3/+1
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge pull request #30113 from dixpac/remove_unecessary_require_in_test_helperRafael França2017-08-111-2/+0
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveStorage: Remove unnecessary require in test_helper
| * | | | | | | | | | | | | | Remove unecessary require in test_helperdixpac2017-08-091-2/+0
| |/ / / / / / / / / / / / /
* | | | | | | | | | | | | | Remove unnedded Active Storage installation stepsRafael Mendonça França2017-08-111-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Active Storage was now merged to master and it is automatically installed in a new application.
* | | | | | | | | | | | | | Merge pull request #29720 from gaurish/ar_find_error_message_improvementRafael França2017-08-114-7/+11
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Return Not found Ids in ActiveRecord::NotFound
| * | | | | | | | | | | | | | Return Not found Ids in ActiveRecord::NotFoundGaurish Sharma2017-07-294-7/+11
| | |_|_|_|_|_|_|_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This builds on top of 15e2da656f41af0124f7577858536f3b65462ad5. now it also returns exact Ids which were not found which will be debugging simple.
* | | | | | | | | | | | | | Merge pull request #30193 from zverok/robust-postgres-duplicate-dbRafael França2017-08-111-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | More robust PostgreSQL database duplication check
| * | | | | | | | | | | | | | Update database duplication checkzverok2017-08-111-1/+1
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Merge pull request #30201 from ↵Rafael França2017-08-111-12/+8
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/eval_active_storage_attached_name_only_once Evaluate `@active_storage_attached_#{name}` only once
| * | | | | | | | | | | | | | | Evaluate `@active_storage_attached_#{name}` only onceRyuta Kamizono2017-08-121-12/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `"@active_storage_attached_#{name}"` in `define_method` is evaluated every call. It is better to evaluate it only once.
* | | | | | | | | | | | | | | | Merge pull request #30202 from kamipo/add_null_false_to_active_storage_tablesRafael França2017-08-111-10/+10
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `null: false` to Active Storage tables
| * | | | | | | | | | | | | | | | Add `null: false` to Active Storage tablesRyuta Kamizono2017-08-121-10/+10
| |/ / / / / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These columns aren't intended nullable.
* | | | | | | | | | | | | | | | Specify `table.name` only when `scope.table` and `table` are different (#29058)Ryuta Kamizono2017-08-112-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #29045.
* | | | | | | | | | | | | | | | Remove unused `close_connection` in Action Cable tests (#30195)Ryuta Kamizono2017-08-112-8/+0
| | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | Enable browser caching for blobs and variants (#30196)Anton Khamets2017-08-113-0/+17
|/ / / / / / / / / / / / / / /
* | | | | | | | | | | | | | | Microsoft Azure --> Microsoft Azure Storage [ci skip]Ryuta Kamizono2017-08-121-1/+1
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Refactor app_generator_test (#30192)yhirano552017-08-111-1/+8
| | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | Merge pull request #30186 from yhirano55/fix_generator_example_codeRobin Dupret2017-08-111-2/+2
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix generator example code [ci skip]
| * | | | | | | | | | | | | | | Fix example codes for generators guide [ci skip]Yoshiyuki Hirano2017-08-111-2/+2
| | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | Merge pull request #30197 from ohbarye/fix-rdoc-code-formattingRyuta Kamizono2017-08-113-7/+7
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / / / / / / / |/| | | | | | | | | | | | | | | Fix RDoc formatting: `+` doesn't work with `@` [ci skip]
| * | | | | | | | | | | | | | | Fix RDoc formatting: `+` doesn't work with `@`ohbarye2017-08-113-7/+7
|/ / / / / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | refs: https://github.com/rails/rails/pull/30161 ``` $ echo "+@size+" | rdoc --pipe <p>+@size+</p> $ echo "<tt>@size</tt>" | rdoc --pipe <p><code>@size</code></p> ``` [ci skip]
* | | | | | | | | | | | | | | Merge pull request #30190 from ydakuka/patch-1Vipul A M2017-08-111-2/+2
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] Update testing.md [ci skip]
| * | | | | | | | | | | | | | | Update testing.mdYauheni Dakuka2017-08-111-2/+2
|/ / / / / / / / / / / / / / /
* | | | | | | | | | | | | | | Merge pull request #30189 from koic/fix_formatting_of_active_storage_docsRyuta Kamizono2017-08-117-33/+33
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|_|_|_|/ / / |/| | | | | | | | | | | | | | Fix formatting of Active Storage docs [ci skip]
| * | | | | | | | | | | | | | Fix formatting of Active Storage docs [ci skip]Koichi ITO2017-08-117-33/+33
|/ / / / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up of #30188.
* | | | | | | | | | | | | | Merge pull request #30188 from y-yagi/fix_formatting_of_active_storage_docsRyuta Kamizono2017-08-119-36/+36
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|/ / / / / / |/| | | | | | | | | | | | | Fix formatting of Active Storage docs [ci skip]
| * | | | | | | | | | | | | Fix formatting of Active Storage docs [ci skip]yuuji.yaginuma2017-08-119-36/+36
|/ / / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use `+` instead of backquote. * Remove escape from class to be link
* | | | | | | | | | | / / Run Active Storage tests in CI (#30144)George Claghorn2017-08-106-21/+21
| |_|_|_|_|_|_|_|_|_|/ / |/| | | | | | | | | | |
* | | | | | | | | | | | Merge pull request #30183 from kamipo/reaper_run_after_conn_pool_initializedMatthew Draper2017-08-111-2/+3
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Start `@reaper.run` after connection pool initialized
| * | | | | | | | | | | | Start `@reaper.run` after connection pool initializedRyuta Kamizono2017-08-111-2/+3
| | |_|/ / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise `ConnectionPool#reap` may run before `@connections` has initialized. https://travis-ci.org/rails/rails/jobs/263037427#L888-L890
* | | | | | | | | | | | Isolate ActiveStorage namespaces (#30095)Dino Maric2017-08-102-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Isolate ActiveStorage namespaces * Rename migrations task [Rafael Mendonça França + Dino Maric]
* | | | | | | | | | | | Merge pull request #30164 from bogdanvlviv/improve-railties-generators-testsRafael França2017-08-104-45/+85
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Improve railties generators tests
| * | | | | | | | | | | | `--skip-action-cable` pass throughs `rails plugin new`bogdanvlviv2017-08-103-1/+11
| | | | | | | | | | | | |
| * | | | | | | | | | | | Improve plugin generator tests. Related to #30123.bogdanvlviv2017-08-102-44/+74
| |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve app generator tests. Ensure that generation `config/application.rb` is correct. Ensure that generation `config/application.rb` is correct.
* | | | | | | | | | | | Merge pull request #30152 from bogdanvlviv/fix_random_ci_failureMatthew Draper2017-08-101-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Fix random CI failure due to non-deterministic sorting order
| * | | | | | | | | | | | Fix random CI failure due to non-deterministic sorting orderbogdanvlviv2017-08-091-1/+1
| |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` rails/activerecord$ bundle exec rake postgresql:test --verbose TESTOPTS="--seed=36062" Failure: AssociationsJoinModelTest#test_has_many_through_polymorphic_has_one [/home/travis/build/rails/rails/activerecord/test/cases/associations/join_model_test.rb:407]: --- expected +++ actual @@ -1 +1 @@ -[ #<Tagging id: 1, tag_id: 1, super_tag_id: 2, taggable_type: "Post", taggable_id: 1, comment: nil>, #<Tagging id: 2, tag_id: 1, super_tag_id: nil, taggable_type: "Post", taggable_id: 2, comment: nil> ] +#<ActiveRecord::Associations::CollectionProxy [ #<Tagging id: 2, tag_id: 1, super_tag_id: nil, taggable_type: "Post", taggable_id: 2, comment: nil>, #<Tagging id: 1, tag_id: 1, super_tag_id: 2, taggable_type: "Post", taggable_id: 1, comment: nil> ]> ```
* | | | | | | | | | | | Merge pull request #30174 from qsona/storageRyuta Kamizono2017-08-101-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / / / |/| | | | | | | | | | | Fix a typo in code comment [ci skip]
| * | | | | | | | | | | Fix a typoqsona2017-08-101-1/+1
|/ / / / / / / / / / /
* | | | | | | | | | | Revert "Revert "Set Ruby version in Gemfile and .ruby-version by default""David Heinemeier Hansson2017-08-094-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a8f59044fb18ce718367ffe4cd3ec0259c766b5f. See discussion on https://github.com/rails/rails/pull/30016.
* | | | | | | | | | | Revert "Set Ruby version in Gemfile and .ruby-version by default"schneems2017-08-094-24/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit fd7f978a5068921380308fe439af3923566c8f61.
* | | | | | | | | | | Merge pull request #30170 from bogdanvlviv/fix_random_ci_failure_ar_dirtyRafael França2017-08-091-4/+3
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|/ / |/| | | | | | | | | | Fix random CI failure DirtyTest
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 20:50:27 +0000