aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYoshiyuki Hirano <yhirano@me.com>2017-08-07 18:10:31 +0900
committerYoshiyuki Hirano <yhirano@me.com>2017-08-09 07:21:37 +0900
commit59f93bbce79407c64636280dc9dfe1170f8b5078 (patch)
tree8fa8d3cf427e6f9c9607340e2704b39c4cda0d0c
parent220049fb32152aa3e1124f77c3d7ee8d0347a9ed (diff)
downloadrails-59f93bbce79407c64636280dc9dfe1170f8b5078.tar.gz
rails-59f93bbce79407c64636280dc9dfe1170f8b5078.tar.bz2
rails-59f93bbce79407c64636280dc9dfe1170f8b5078.zip
Add git_source to Gemfile for plugin generator
-rw-r--r--railties/CHANGELOG.md4
-rw-r--r--railties/lib/rails/generators/rails/plugin/templates/Gemfile1
-rw-r--r--railties/test/generators/plugin_generator_test.rb5
3 files changed, 10 insertions, 0 deletions
diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md
index 73793be78c..44449dac0e 100644
--- a/railties/CHANGELOG.md
+++ b/railties/CHANGELOG.md
@@ -1,3 +1,7 @@
+* Add git_source to `Gemfile` for plugin generator
+
+ *Yoshiyuki Hirano*
+
* Deprecate support of use `Rails::Application` subclass to start Rails server.
*Yuji Yaginuma*
diff --git a/railties/lib/rails/generators/rails/plugin/templates/Gemfile b/railties/lib/rails/generators/rails/plugin/templates/Gemfile
index 22a4548ff2..290259b4db 100644
--- a/railties/lib/rails/generators/rails/plugin/templates/Gemfile
+++ b/railties/lib/rails/generators/rails/plugin/templates/Gemfile
@@ -1,4 +1,5 @@
source 'https://rubygems.org'
+git_source(:github) { |repo| "https://github.com/#{repo}.git" }
<% if options[:skip_gemspec] -%>
<%= '# ' if options.dev? || options.edge? -%>gem 'rails', '<%= Array(rails_version_specifier).join("', '") %>'
diff --git a/railties/test/generators/plugin_generator_test.rb b/railties/test/generators/plugin_generator_test.rb
index 1dfff38543..0782e1ad1d 100644
--- a/railties/test/generators/plugin_generator_test.rb
+++ b/railties/test/generators/plugin_generator_test.rb
@@ -82,6 +82,11 @@ class PluginGeneratorTest < Rails::Generators::TestCase
assert_file "test/integration/navigation_test.rb", /ActionDispatch::IntegrationTest/
end
+ def test_inclusion_of_git_source
+ run_generator [destination_root]
+ assert_file "Gemfile", /git_source/
+ end
+
def test_inclusion_of_a_debugger
run_generator [destination_root, "--full"]
if defined?(JRUBY_VERSION) || RUBY_ENGINE == "rbx"