aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * Extract test helper for image blob fixturesDavid Heinemeier Hansson2017-07-213-7/+9
| |
| * Fix parens after inline blockDavid Heinemeier Hansson2017-07-211-1/+1
| |
| * Actually we just want them mounted straightDavid Heinemeier Hansson2017-07-211-1/+1
| |
| * Provide directed URL as well as resolvingDavid Heinemeier Hansson2017-07-211-4/+7
| |
| * Proper requireDavid Heinemeier Hansson2017-07-211-1/+1
| |
| * Fix and test VariantsControllerDavid Heinemeier Hansson2017-07-215-12/+36
| |
| * Over-indentedDavid Heinemeier Hansson2017-07-211-2/+2
| |
| * Precise namingDavid Heinemeier Hansson2017-07-211-1/+1
| |
| * Extract variation value objectDavid Heinemeier Hansson2017-07-216-65/+84
| |
| * Hacky way to mount routes for engine controller testsDavid Heinemeier Hansson2017-07-211-0/+11
| |
| * Mount routes on the engineDavid Heinemeier Hansson2017-07-211-1/+1
| |
| * Accept that this is a full-Rails engineDavid Heinemeier Hansson2017-07-212-9/+46
| |
| * Better namingDavid Heinemeier Hansson2017-07-211-2/+3
| |
| * True is the same as no argumentsDavid Heinemeier Hansson2017-07-201-3/+4
| |
| * Consistent namingDavid Heinemeier Hansson2017-07-201-2/+2
| |
| * Make processing an explicit stepDavid Heinemeier Hansson2017-07-202-7/+9
| |
| * Fix-up variants controllerDavid Heinemeier Hansson2017-07-202-22/+11
| |
| * Move controllers to default engine location for auto loadingDavid Heinemeier Hansson2017-07-204-14/+23
| |
| * Extract routes.rb to engine location for auto configurationDavid Heinemeier Hansson2017-07-204-25/+13
| |
| * Use the direct accessorDavid Heinemeier Hansson2017-07-201-3/+1
| |
| * Use a unique blob variant key for storageDavid Heinemeier Hansson2017-07-201-2/+10
| |
| * Do real transformations in a safe wayDavid Heinemeier Hansson2017-07-201-4/+20
| |
| * Follow AR like naming of factory methodDavid Heinemeier Hansson2017-07-202-2/+2
| |
| * Easier access to the variant of a blobDavid Heinemeier Hansson2017-07-201-0/+5
| |
| * Double confettiDavid Heinemeier Hansson2017-07-201-2/+0
| |
| * Merge branch 'master' into variantsDavid Heinemeier Hansson2017-07-2025-107/+359
| |\ | |/ |/|
* | Accept S3 upload options (e.g. server_side_encryption)James Baer2017-07-202-3/+23
| |
* | Use descriptive new freeze_time helperGeorge Claghorn2017-07-194-4/+4
| |
* | Replace hard-coded S3 bucket name with configured bucketJames T. Perreault2017-07-172-2/+2
| |
* | Remove unused requireGeorge Claghorn2017-07-171-1/+0
| |
* | Add direct upload support to GCS serviceMichael Herold2017-07-173-2/+63
| |
* | Splat optionsGeorge Claghorn2017-07-161-16/+2
| |
* | Fix S3 direct upload testGeorge Claghorn2017-07-161-13/+3
| |
* | Merge pull request #56 from colorfulfool/fix-s3-serviceGeorge Claghorn2017-07-151-3/+1
|\ \ | | | | | | Fix a typo in S3Service
| * | Fix a typo in S3Servicecolorfulfool2017-07-161-3/+1
|/ /
* | Swap branchesGeorge Claghorn2017-07-151-3/+3
| |
* | Merge pull request #48 from seanhandley/hosted_s3George Claghorn2017-07-151-2/+18
|\ \ | | | | | | Allow custom endpoints for S3.
| * | Allow custom endpoints for S3.Sean Handley2017-07-151-2/+18
| | |
* | | Put conditional backGeorge Claghorn2017-07-141-2/+2
| | |
* | | Merge pull request #55 from SGospodinov/logger-for-5.2.0George Claghorn2017-07-141-3/+3
|\ \ \ | | | | | | | | Fixing logger to work with Rails 5.2.0.alpha
| * | | Fixing logger to work with Rails 5.2.0.alphaStanislav Gospodinov2017-07-151-3/+3
|/ / /
* | | Depend on Rails >= 5.2.0.alphaGeorge Claghorn2017-07-143-35/+51
| | |
* | | Merge pull request #53 from colorfulfool/error-messagesGeorge Claghorn2017-07-142-2/+5
|\ \ \ | | | | | | | | Useful error messages for two possible misconfigurations
| * | | Fail early if no storage service is specifiedcolorfulfool2017-07-151-0/+3
| | | |
| * | | Don't fail on boot because of missing S3 keys when S3 is not usedcolorfulfool2017-07-151-2/+2
| |/ /
* | | Merge pull request #51 from dixpac/restore_intermediate_variablesGeorge Claghorn2017-07-141-2/+8
|\ \ \ | |/ / |/| | Revert back to the original implementaion with varaibles
| * | Revert back to the original implementaion with varaiblesdixpac2017-07-141-2/+8
|/ / | | | | | | | | | | Revert `exist? and url` to the original implementation. Since the new one doesn't provide any benefits and makes implementation harder to follow.
* | Added rubocop / codeclimate config and fixed current offenses (#45)Cristian Bica2017-07-1418-33/+183
| |
* | Fix regular expression on s3 test URL generation test (#44)Dino Maric2017-07-131-5/+5
| | | | | | | | | | | | | | So tests are passing if the bucket name is rails-active storage. But developers specify their own s3 tests configuration (in my case was activestorage-test) then this regex fails. Also the first part is dynamic and based on bucket name and region
* | Merge pull request #43 from dixpac/small_gcs_service_refactoringGeorge Claghorn2017-07-131-8/+2
|\ \ | | | | | | Remove unnecessary variables from gcs_service implementation