| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
We added a deprecation warning for these cases in aa1fadd, so these are now
causing deprecation warnings in the test output. AFAICT, in these two cases, the
option is not integral to the purpose of the test, so they can be safely removed
|
|
|
|
|
|
| |
Follow up to 212057b9. Since that commit, we need to pass the `route_name`
explicitly. This is one of the left-over cases that was not handled in that
commit, which was causing `use_route` to be ignored in functional tests.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why are people assigning booleans to string columns? >_>
We unintentionally changed the behavior on Sqlite3 and PostgreSQL.
Boolean values should cast to the database's representation of true and
false. This is 't' and 'f' by default, and "1" and "0" on Mysql. The
implementation to make the connection adapter specific behavior is hacky
at best, and should be re-visted once we decide how we actually want to
separate the concerns related to things that should change based on the
database adapter.
That said, this isn't something I'd expect to change based on my
database adapter. We're storing a string, so the way the database
represents a boolean should be irrelevant. It also seems strange for us
to give booleans special behavior at all in string columns. Why is
`to_s` not sufficient? It's inconsistent and confusing. Perhaps we
should consider deprecating in the future.
Fixes #17571
|
|\
| |
| | |
Fixed grammar about AS::Notifications [ci skip]
|
|/
|
|
| |
active_support/notifications [ci skip]
|
|\
| |
| | |
Ensure HABTM relationships produce valid class names (Fixes #17119)
|
|/ |
|
|\
| |
| | |
[ci skip] Fix typo in command_line.md
|
|/ |
|
|\
| |
| | |
[ci skip] Fix comment of SourceAnnotationExtractor#find_in
|
|/
|
|
|
|
| |
Commit(810af6f) changed which extensions are taken into account,
so make to match comment of find_in.
And sort extensions to follow the added order.
|
| |
|
|\
| |
| | |
[ci skip] Fix line break on command line guide
|
| | |
|
|\ \
| | |
| | | |
default scopes should break the cache on singulur_association.
|
| |/
| |
| |
| | |
fixes #17495
|
|\ \
| |/
|/| |
Add a section about job testing [ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| | |
* Cover lower level job testing (assertions about the execution of the
job itself).
* Add a table with the custom assertions provided by Active Job's
`TestHelper` module.
* Add an example testing job queuing inside a model
|
|\ \
| | |
| | | |
Delegate comparison operator to value
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
if you specify a default scope on a model, it will break caching. We
cannot predict what will happen inside the scope, so play it safe for
now. fixes #17495
|
|\ \ \
| | | |
| | | | |
Guides: Corrected name for assigns key [ci skip]
|
|/ / /
| | |
| | |
| | |
| | | |
- Integration test example is now using 'articles' name
for both path and assigns key.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
[ci skip] modify default host in command line guide
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | | |
Print out a meaningful error when ActiveRecord::ReadOnlyRecord is raised
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
Currently, there is no messages which get printed out. Convoluted system
may have hooks that create other objects in which case we only fail with
no messages. This commit changes this information allowing you to know
which object is the one that actually raised the error.
|
|\ \ \
| | | |
| | | | |
[Enh] Made the ActiveModel::Dirty#clear_attribute_changes method public
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
ActiveModel::Dirty#clear_attribute_changes method
In Rails 4.2 it is impossible to define a custom default value for a model's
attribute without making it appear as _changed?, especially when the model
is first initialized. Making this method publicly visible will allow such a behaviour,
without the need to use private APIs.
|
|\ \ \ \
| |/ / /
|/| | | |
added example of hash#except, and removed extra whitespaces [ci skip]
|
|/ / / |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
This makes debugging the generated schema output much easier.
As a side effect it also shaves off 2.5 seconds of test runtime.
|
|\ \ \
| | | |
| | | | |
Remove session to allow `with_routing` to be called twice.
|
| | | |
| | | |
| | | |
| | | | |
Fixes: https://github.com/rails/rails/issues/16814
|
|\ \ \ \
| | | | |
| | | | | |
Fixed grouped expression warning
|
|/ / / /
| | | |
| | | |
| | | | |
expression`
|
|\ \ \ \
| | | | |
| | | | | |
Update docs 6
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
pattern removal
added example for string#remove and test case for remove of multiple occurence of pattern
removed extra whitespaces
|
| | | | |
| | | | |
| | | | |
| | | | | |
/cc @chancancode
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove redundancy [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I love this guide!
and "visually see" is redundant.
remove "visually", then the sentence reads:
> Action Mailer previews provide a way to see how emails look
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Replace Html with HTML [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
- Everywhere else we using HTML Sanitizer except this place.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
[docs] Removed respond_with documentation as it was deprecated and removed from Rails [ci-skip]
|