diff options
| author | Godfrey Chan <godfreykfc@gmail.com> | 2014-11-10 00:47:25 -0800 |
|---|---|---|
| committer | Godfrey Chan <godfreykfc@gmail.com> | 2014-11-10 00:47:25 -0800 |
| commit | 6625000b73f520abf6e0afbd5a6dde8d6b06b7cc (patch) | |
| tree | 0563e8af9bd658fc1f1aef6367018b30b7c0512c | |
| parent | aa6637d140c2ebd28bbd23fc250af033a065dbe8 (diff) | |
| download | rails-6625000b73f520abf6e0afbd5a6dde8d6b06b7cc.tar.gz rails-6625000b73f520abf6e0afbd5a6dde8d6b06b7cc.tar.bz2 rails-6625000b73f520abf6e0afbd5a6dde8d6b06b7cc.zip | |
Remove useless `only_path: true` in path helpers
We added a deprecation warning for these cases in aa1fadd, so these are now
causing deprecation warnings in the test output. AFAICT, in these two cases, the
option is not integral to the purpose of the test, so they can be safely removed
| -rw-r--r-- | actionpack/test/controller/url_for_test.rb | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/actionpack/test/controller/url_for_test.rb b/actionpack/test/controller/url_for_test.rb index 969129d9ba..c05cde87e4 100644 --- a/actionpack/test/controller/url_for_test.rb +++ b/actionpack/test/controller/url_for_test.rb @@ -25,8 +25,7 @@ module AbstractController path = klass.new.fun_path({:controller => :articles, :baz => "baz", - :zot => "zot", - :only_path => true }) + :zot => "zot"}) # :bar key isn't provided assert_equal '/foo/zot', path end @@ -291,7 +290,7 @@ module AbstractController assert_equal '/brave/new/world', controller.url_for(:controller => 'brave', :action => 'new', :id => 'world', :only_path => true) - assert_equal("/home/sweet/home/alabama", controller.home_path(:user => 'alabama', :host => 'unused', :only_path => true)) + assert_equal("/home/sweet/home/alabama", controller.home_path(:user => 'alabama', :host => 'unused')) assert_equal("/home/sweet/home/alabama", controller.home_path('alabama')) end end |