| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| | |
This is a follow up to https://github.com/rails/rails/commit/07786c5e75a7b0afdf318063510af6b475e3e04c
and https://github.com/rails/rails/commit/cd2596f55e88fe659592612a793c4f4aa723c9be
|
|\ \
| | |
| | | |
Fix OR in Journey patterns
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
tgxworld/fix_extracated_default_value_for_negative_integers
Fix value extracted from negative integers for PostgreSQL.
|
|/ / /
| | |
| | |
| | | |
Fixes: https://github.com/rails/rails/issues/17856.
|
|\ \ \
| | | |
| | | | |
Pretty-print request params on exception page
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The detection of in-place changes caused a weird unexpected issue with
numericality validations. That validator (out of necessity) works on the
`_before_type_cast` version of the attribute, since on an `:integer`
type column, a non-numeric string would type cast to 0.
However, strings are mutable, and we changed strings to ensure that the
post type cast version of the attribute was a different instance than
the before type cast version (so the mutation detection can work
properly).
Even though strings are the only mutable type for which a numericality
validation makes sense, special casing strings would feel like a strange
change to make here. Instead, we can make the assumption that for all
mutable types, we should work on the post-type-cast version of the
attribute, since all cases which would return 0 for non-numeric strings
are immutable.
Fixes #17852
|
|\ \ \
| | | |
| | | | |
FIX: absolute_path may be nil for code added via instance_eval
|
|/ / / |
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- In guides, "API" is used consistently instead of "api".
- Reason behind replacing "fixtures API" to "Fixtures API" is because
here we are referring to the concept of "fixtures". In other places in
the guide "fixture" OR "fixtures" is referred to the single or
multiple instances of test data.
- This is also followup of https://github.com/rails/docrails/commit/aa9d1332b20305dd860b21a7ada06c5252bebad5#commitcomment-8497376.
|
| | | |
|
|\ \ \
| | | |
| | | | |
[ci skip] fix description of url_for
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | | |
`where_sql` now requires that we pass it an engine. None of the manager
classes take an engine in their constructor.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We never actually make use of it on the table, since we're constructing
the select manager manually. It looks like if we ever actually were
grabbing it from the table, we're grossly misusing it since it's meant
to vary by AR class.
Its existence on `Arel::Table` appears to be purely for convenience
methods that are never used outside of tests. However, in production
code it just complicates construction of the tables on the rails side,
and the plan is to remove it from `Arel::Table` entirely. I'm not
convinced it needs to live on `SelectManager`, etc either.
|
|\ \ \
| | | |
| | | | |
Pure rack apps can be mounted with a name
|
| | | |
| | | |
| | | |
| | | | |
See https://github.com/rails/rails/commit/9b15828b5c347395b42066a588c88e5eb4e72279#commitcomment-8764492
|
|\ \ \ \
| | | | |
| | | | | |
Fix link in documentation. [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Bump ruby version to 2.1.0 in rails.gemspec too.
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Pass symbol as an argument instead of a block
|
|/ / / / |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Prevent Numeric#to_s from allocating an array
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Bump required Ruby version to 2.1.0
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
[This article](http://weblog.rubyonrails.org/2014/8/20/Rails-4-2-beta1/#maintenance-consequences-and-rails-5-0) states that:
> Rails 5.0 is in most likelihood going to target Ruby 2.2.
Before the exact minimum version is fully decided, @arthurnn [suggests](https://github.com/rails/rails/pull/17830#issuecomment-64940383)
that **at least** version 2.1.0 **must** be required by the `gemspec` files.
|
|\ \ \ \
| | | | |
| | | | | |
Remove a reference to Ruby 1.9 in Guides
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
[ci skip]
Now that Rails requires Ruby >= 2.0 there is no need to document
Ruby 1.9.
|
|\ \ \ \
| |_|/ /
|/| | | |
[ci skip] fix class name
|
|/ / / |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
fixed indent of end in jdom.rb
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Refactor `add_column_options!`, to move the quoting of default value for :uuid in `quote_value`.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
:uuid in `quote_value`.
|
| |/ / /
|/| | |
| | | |
| | | | |
delayed_job_active_record doesn't allow Rails 5 yet
|
| | | | |
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | | |
We will support only Ruby >= 2.1.
But right now we don't accept pull requests with syntax changes to drop
support to Ruby 1.9.
|
|\ \ \
| | | |
| | | | |
4.2 release notes pass [skip ci]
|
| | |/
| |/| |
|
|\ \ \
| |/ /
|/| | |
Adds preloaded_records method to NullPreloader - fixes #16070
|