aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | Merge pull request #16535 from bf4/patch-1Rafael Mendonça França2014-11-109-23/+180
| |\ \ \ \ \ | | |/ / / / | |/| | | | | | | | | | Allow fallback to LegacyKeyGenerator when secret_key_base is not set but secrets.secret_token is
| | * | | | `secret_token` is now saved in `Rails.application.secrets.secret_token`Benjamin Fleischer2014-11-029-23/+180
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - `secrets.secret_token` is now used in all places `config.secret_token` was - `secrets.secret_token`, when not present in `config/secrets.yml`, now falls back to the value of `config.secret_token` - when `secrets.secret_token` is set, it over-writes `config.secret_token` so they are the same (for backwards-compatibility) - Update docs to reference app.secrets in all places - Remove references to `config.secret_token`, `config.secret_key_base` - Warn that missing secret_key_base is deprecated - Add tests for secret_token, key_generator, and message_verifier - the legacy key generator is used with the message verifier when secrets.secret_key_base is blank and secret_token is set - app.key_generator raises when neither secrets.secret_key_base nor secret_token are set - app.env_config raises when neither secrets.secret_key_base nor secret_token are set - Add changelog Run focused tests via ruby -w -Itest test/application/configuration_test.rb -n '/secret_|key_/'
* | | | | | dependencies.rb: keep the decorated #load and #require private [closes #17553]Xavier Noria2014-11-103-13/+36
| | | | | |
* | | | | | Merge pull request #17585 from aderyabin/remove_limited_update_conditionsRafael Mendonça França2014-11-102-8/+0
|\ \ \ \ \ \ | |/ / / / / |/| | | | | remove never called method `limited_update_conditions`
| * | | | | remove never called method `limited_update_conditions`Andrey Deryabin2014-11-112-8/+0
| | | | | |
* | | | | | Merge pull request #17579 from aderyabin/cleanup_sqliteRafael Mendonça França2014-11-101-6/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Tiny improvement in sqlite3 adapter
| * | | | | | tiny code improvement in sqlite3 adapter:Andrey Deryabin2014-11-101-6/+2
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | - remove unused method `supports_add_column?` - change additional restriction method to `valid_alter_table_type?` - fix code style
* | | | | | Merge pull request #17578 from codeodor/fix-17217-test-bugRafael Mendonça França2014-11-101-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix bug found when running individual tests against #17217 after merging
| * | | | | | Fixes a bug found when running individual tests against #17217 after mergingSammy Larbi2014-11-101-1/+1
| |/ / / / /
* | | | | | Merge pull request #11694 from ↵Rafael Mendonça França2014-11-103-1/+20
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Empact/association-bind-values-not-updated-on-save Fix that a collection proxy could be cached before the save of the owner, resulting in an invalid proxy lacking the owner’s id Conflicts: activerecord/CHANGELOG.md
| * | | | | Fix that a collection proxy could be cached before the save of the owner, ↵Ben Woosley2014-10-033-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | resulting in an invalid proxy lacking the owner’s id. Absent this fix calls like: owner.association.update_all to behave unexpectedly because they try to act on association objects where owner_id is null. more evidence here: https://gist.github.com/Empact/5865555 ``` Active Record 3.2.13 -- create_table(:firms, {:force=>true}) -> 0.1371s -- create_table(:clients, {:force=>true}) -> 0.0005s 1 clients. 1 expected. 1 clients updated. 1 expected. ``` ``` Active Record 4.0.0 -- create_table(:firms, {:force=>true}) -> 0.1606s -- create_table(:clients, {:force=>true}) -> 0.0004s 1 clients. 1 expected. 0 clients updated. 1 expected. ```
* | | | | | docs, minor changes in Active Job documentation. [ci skip]Yves Senn2014-11-102-6/+5
| | | | | |
* | | | | | Remove useless `only_path: true` in path helpersGodfrey Chan2014-11-101-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We added a deprecation warning for these cases in aa1fadd, so these are now causing deprecation warnings in the test output. AFAICT, in these two cases, the option is not integral to the purpose of the test, so they can be safely removed
* | | | | | Pass the route name explicitlyGodfrey Chan2014-11-102-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to 212057b9. Since that commit, we need to pass the `route_name` explicitly. This is one of the left-over cases that was not handled in that commit, which was causing `use_route` to be ignored in functional tests.
* | | | | | Revert the behavior of booleans in string columns to that of 4.1Sean Griffin2014-11-093-7/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Why are people assigning booleans to string columns? >_> We unintentionally changed the behavior on Sqlite3 and PostgreSQL. Boolean values should cast to the database's representation of true and false. This is 't' and 'f' by default, and "1" and "0" on Mysql. The implementation to make the connection adapter specific behavior is hacky at best, and should be re-visted once we decide how we actually want to separate the concerns related to things that should change based on the database adapter. That said, this isn't something I'd expect to change based on my database adapter. We're storing a string, so the way the database represents a boolean should be irrelevant. It also seems strange for us to give booleans special behavior at all in string columns. Why is `to_s` not sufficient? It's inconsistent and confusing. Perhaps we should consider deprecating in the future. Fixes #17571
* | | | | | Merge pull request #17572 from rishijain/update_docs_10Zachary Scott2014-11-093-1/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fixed grammar about AS::Notifications [ci skip]
| * | | | | | added description for rails generators, and fixed sentence formation for ↵Rishi Jain2014-11-103-1/+5
|/ / / / / / | | | | | | | | | | | | | | | | | | active_support/notifications [ci skip]
* | | | | | Merge pull request #17217 from codeodor/fix-17119Aaron Patterson2014-11-097-3/+25
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Ensure HABTM relationships produce valid class names (Fixes #17119)
| * | | | | Ensure HABTM relationships produce valid class names (Fixes #17119)Sammy Larbi2014-11-097-3/+25
|/ / / / /
* | | | | Merge pull request #17564 from yui-knk/fix/command_line_guideRobin Dupret2014-11-091-1/+1
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Fix typo in command_line.md
| * | | | | [ci skip] Fix typo in command_line.mdyui-knk2014-11-091-1/+1
|/ / / / /
* | | | | Merge pull request #17563 from yui-knk/fix/source_annotation_extractorZachary Scott2014-11-081-3/+2
|\ \ \ \ \ | |_|_|_|/ |/| | | | [ci skip] Fix comment of SourceAnnotationExtractor#find_in
| * | | | Fix comment of SourceAnnotationExtractor#find_inyui-knk2014-11-091-3/+2
|/ / / / | | | | | | | | | | | | | | | | | | | | Commit(810af6f) changed which extensions are taken into account, so make to match comment of find_in. And sort extensions to follow the added order.
* | | | Documenting Rails::Info module [ci skip]Zachary Scott2014-11-081-0/+3
| | | |
* | | | Merge pull request #17557 from yui-knk/fix/command_line_guideVijay Dev2014-11-081-6/+2
|\ \ \ \ | | | | | | | | | | [ci skip] Fix line break on command line guide
| * | | | [ci skip] Fix line break on command line guideyui-knk2014-11-081-6/+2
| | | | |
* | | | | Merge pull request #17559 from alfa-jpn/fix/singular_association_cacheSantiago Pastorino2014-11-082-1/+31
|\ \ \ \ \ | | | | | | | | | | | | default scopes should break the cache on singulur_association.
| * | | | | default scopes should break the cache on singulur_association.alfa-jpn2014-11-082-1/+31
| |/ / / / | | | | | | | | | | | | | | | fixes #17495
* | | | | Merge pull request #17476 from robin850/job-testingRobin Dupret2014-11-081-0/+62
|\ \ \ \ \ | |/ / / / |/| | | | Add a section about job testing [ci skip]
| * | | | Add a section about job testing [ci skip]Ryan Selk2014-11-021-0/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Cover lower level job testing (assertions about the execution of the job itself). * Add a table with the custom assertions provided by Active Job's `TestHelper` module. * Add an example testing job queuing inside a model
* | | | | Merge pull request #17493 from petewest/duration-comparableAaron Patterson2014-11-072-0/+14
|\ \ \ \ \ | | | | | | | | | | | | Delegate comparison operator to value
| * | | | | Delegate comparison operator to valuePeter West2014-11-032-0/+14
| | | | | |
* | | | | | default scopes should break the cache on has_many.Aaron Patterson2014-11-072-1/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if you specify a default scope on a model, it will break caching. We cannot predict what will happen inside the scope, so play it safe for now. fixes #17495
* | | | | | Merge pull request #17552 from jipe/masterYves Senn2014-11-071-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Guides: Corrected name for assigns key [ci skip]
| * | | | | | Guides: Corrected name for assigns key [ci skip]Jimmy Petersen2014-11-071-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | - Integration test example is now using 'articles' name for both path and assigns key.
* | | | | | pg tests, get rid of `sql_types_test.rb`.Yves Senn2014-11-073-18/+14
| | | | | |
* | | | | | pg tests, only execute what's necessary.Yves Senn2014-11-072-27/+26
| | | | | |
* | | | | | remove the last traces of OpenBase from our codebase. [ci skip]Yves Senn2014-11-071-6/+0
| | | | | |
* | | | | | docs, the abstract data type `:timestamp` was removed. See #15184 [ci skip]Yves Senn2014-11-071-2/+2
| | | | | |
* | | | | | Merge pull request #17551 from y-yagi/fix_command_line_guideZachary Scott2014-11-071-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | [ci skip] modify default host in command line guide
| * | | | | | [ci skip] modify default host in command line guideyuuji.yaginuma2014-11-071-2/+2
|/ / / / / /
* | | | | | Merge pull request #17541 from OpenSourceProjects/meaninful_messageYves Senn2014-11-073-5/+15
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Print out a meaningful error when ActiveRecord::ReadOnlyRecord is raised
| * | | | | | Print out a meaningful error when ActiveRecord::ReadOnlyRecord is raisedFranky W2014-11-062-5/+8
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, there is no messages which get printed out. Convoluted system may have hooks that create other objects in which case we only fail with no messages. This commit changes this information allowing you to know which object is the one that actually raised the error.
* | | | | | Merge pull request #17545 from marzapower/dirty_public_apiRafael Mendonça França2014-11-061-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | [Enh] Made the ActiveModel::Dirty#clear_attribute_changes method public
| * | | | | | [Enh] Changed the visibility of the ↵Daniele Di Bernardo2014-11-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveModel::Dirty#clear_attribute_changes method In Rails 4.2 it is impossible to define a custom default value for a model's attribute without making it appear as _changed?, especially when the model is first initialized. Making this method publicly visible will allow such a behaviour, without the need to use private APIs.
* | | | | | | Merge pull request #17543 from rishijain/update_docs_9Rafael Mendonça França2014-11-062-5/+11
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | added example of hash#except, and removed extra whitespaces [ci skip]
| * | | | | | added example of hash#except, and removed extra whitespaces [ci skip]Rishi Jain2014-11-072-5/+11
|/ / / / / /
* | | | | | tests, remove unneeded requires.Yves Senn2014-11-064-11/+0
| | | | | |
* | | | | | tests, use SchemaDumpingHelper to dump a specific table.Yves Senn2014-11-061-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes debugging the generated schema output much easier. As a side effect it also shaves off 2.5 seconds of test runtime.
* | | | | | Merge pull request #17523 from tgxworld/reset_session_after_calling_with_routingRafael Mendonça França2014-11-063-0/+41
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove session to allow `with_routing` to be called twice.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-11 13:19:59 +0000