diff options
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/CONVENTIONS | 2 | ||||
| -rw-r--r-- | doc/TODO | 7 |
2 files changed, 5 insertions, 4 deletions
diff --git a/doc/CONVENTIONS b/doc/CONVENTIONS index 0d7c1b4ef0..c415a527e1 100644 --- a/doc/CONVENTIONS +++ b/doc/CONVENTIONS @@ -11,7 +11,7 @@ This file should ultimately be replaced by a series of tests, something like a l - 'obtains' is preferred to 'returns true' - 'manufactures' - in tests - - when manufacturing expected values (right-hand-side of should), avoid convenience methods -- construct it by initializing the object directly (Foo.new(...)). This ensures equality expectations in tests is rigorous. + - when manufacturing expected values (right-hand-side of should), avoid convenience methods -- construct it by initializing the object directly (Foo.new(...)). This ensures equality expectations in tests are rigorous. - the SUT should be manufactured inline inside the test, not in a before - dependencies for the SUT should be manufactured using convenience methods (or whatever is most terse). - group conceptually related methods in a class within an inline module; immediately include that module.
\ No newline at end of file @@ -1,4 +1,6 @@ todo: +- test Value, in particular bind. +- test blank checks in relation.rb - mock out database - finish pending tests - test relation, table reset @@ -7,9 +9,6 @@ todo: - "unit" test sql strategies - use real world examples, so they should be like a tutorial. -- string passthrough: - :joins=>"INNER JOIN posts ON comments.post_id = posts.id" - - shit this one is hard at the moment. - cache expiry on write - rewrite of querycache test in light of this @@ -59,6 +58,8 @@ done: - relation inclusion when given an array (1,2,3,4) should quote the elements using the appropriate quoting formatter taken from the attribute - descend on array, along with bind written in terms of it - re-evaluate bind -- does bind belong inside the relation / predicate classes or in the factory methods? +- string passthrough: + :joins=>"INNER JOIN posts ON comments.post_id = posts.id" icebox: - #bind in Attribute and Expression should be doing a descend? |