adding a join factory method on the select manager

2 files changed, 34 insertions, 0 deletions

diff --git a/test/test_select_manager.rb b/test/test_select_manager.rb
index 826832c5ab..2b88022ca3 100644
--- a/test/test_select_manager.rb
+++ b/test/test_select_manager.rb
@@ -277,6 +277,24 @@ module Arel
       end
     end
 
+    it 'should create join nodes' do
+      relation = Arel::SelectManager.new Table.engine
+      join = relation.create_join 'foo', 'bar', 'baz'
+      assert_kind_of Arel::Nodes::InnerJoin, join
+      assert_equal 'foo', join.left
+      assert_equal 'bar', join.right
+      assert_equal 'baz', join.constraint
+    end
+
+    it 'should create join nodes with a klass' do
+      relation = Arel::SelectManager.new Table.engine
+      join = relation.create_join 'foo', 'bar', 'baz', Arel::Nodes::OuterJoin
+      assert_kind_of Arel::Nodes::OuterJoin, join
+      assert_equal 'foo', join.left
+      assert_equal 'bar', join.right
+      assert_equal 'baz', join.constraint
+    end
+
     describe 'join' do
       it 'responds to join' do
         left      = Table.new :users
diff --git a/test/test_table.rb b/test/test_table.rb
index bb7bd255fd..7d773b2e2b 100644
--- a/test/test_table.rb
+++ b/test/test_table.rb
@@ -6,6 +6,22 @@ module Arel
       @relation = Table.new(:users)
     end
 
+    it 'should create join nodes' do
+      join = @relation.create_join 'foo', 'bar', 'baz'
+      assert_kind_of Arel::Nodes::InnerJoin, join
+      assert_equal 'foo', join.left
+      assert_equal 'bar', join.right
+      assert_equal 'baz', join.constraint
+    end
+
+    it 'should create join nodes with a klass' do
+      join = @relation.create_join 'foo', 'bar', 'baz', Arel::Nodes::OuterJoin
+      assert_kind_of Arel::Nodes::OuterJoin, join
+      assert_equal 'foo', join.left
+      assert_equal 'bar', join.right
+      assert_equal 'baz', join.constraint
+    end
+
     it 'should return an insert manager' do
       im = @relation.compile_insert 'VALUES(NULL)'
       assert_kind_of Arel::InsertManager, im