Add a value field `Nodes::BindParam`

This is part of a greater refactoring to have the `BindParam` nodes hold
onto their values. We want to generally keep the AST decoupled from what
you're actually doing with those values, but ultimately the usage of
`BindParam` is almost identical to how you'd use `Casted` or `Quoted`.
Forcing consumers of Arel's API to maintain the bind values separately
from the AST makes manipulating the AST essentially impossible, as you
would need to perform a full walk of the AST to determine whether a
given node contains bind parameters, and which value it maps to.

By storing the value on the bind parameter directly, we can collect them
in another AST pass (realistically it'll be part of the same pass that
performs SQL construction for performance reasons). This will
dramatically simplify AST manipulation for Rails or any other consumers
that work with bind params.

As part of this change I've removed the `BindVisitor`, which appears to
be dead code, and had tests break from this change.

1 files changed, 71 insertions, 0 deletions

diff --git a/test/collectors/test_substitute_bind_collector.rb b/test/collectors/test_substitute_bind_collector.rb
new file mode 100644
index 0000000000..adcaf98319
--- /dev/null
+++ b/test/collectors/test_substitute_bind_collector.rb
@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+require 'helper'
+require 'arel/collectors/substitute_binds'
+
+module Arel
+  module Collectors
+    class TestSubstituteBindCollector < Arel::Test
+      def setup
+        @conn = FakeRecord::Base.new
+        @visitor = Visitors::ToSql.new @conn.connection
+        super
+      end
+
+      def collect node
+        @visitor.accept(node, Collectors::SubstituteBinds.new)
+      end
+
+      def compile node
+        collect(node).value
+      end
+
+      def ast_with_binds bv
+        table = Table.new(:users)
+        manager = Arel::SelectManager.new table
+        manager.where(table[:age].eq(bv))
+        manager.where(table[:name].eq(bv))
+        manager.ast
+      end
+
+      def test_leaves_binds
+        node = Nodes::BindParam.new(nil)
+        list = compile node
+        assert_equal node, list.first
+        assert_equal node.class, list.first.class
+      end
+
+      def test_adds_strings
+        bv = Nodes::BindParam.new(nil)
+        list = compile ast_with_binds bv
+        assert_operator list.length, :>, 0
+        assert_equal bv, list.grep(Nodes::BindParam).first
+        assert_equal bv.class, list.grep(Nodes::BindParam).first.class
+      end
+
+      def test_substitute_binds
+        bv = Nodes::BindParam.new(nil)
+        collector = collect ast_with_binds bv
+
+        values = collector.value
+
+        offsets = values.map.with_index { |v,i|
+          [v,i]
+        }.find_all { |(v,_)| Nodes::BindParam === v }.map(&:last)
+
+        list = collector.substitute_binds ["hello", "world"]
+        assert_equal "hello", list[offsets[0]]
+        assert_equal "world", list[offsets[1]]
+
+        assert_equal 'SELECT FROM "users" WHERE "users"."age" = hello AND "users"."name" = world', list.join
+      end
+
+      def test_compile
+        bv = Nodes::BindParam.new(nil)
+        collector = collect ast_with_binds bv
+
+        sql = collector.compile ["hello", "world"]
+        assert_equal 'SELECT FROM "users" WHERE "users"."age" = hello AND "users"."name" = world', sql
+      end
+    end
+  end
+end