diff options
| author | Caius Durling <dev@caius.name> | 2011-05-31 22:48:40 +0100 |
|---|---|---|
| committer | Caius Durling <dev@caius.name> | 2011-06-21 19:55:21 +0100 |
| commit | 96be08de257460cfd66d7f946be95e07160cea6f (patch) | |
| tree | f65fa6ff7db628bb34f67cfd07bf26739ad188d5 /tasks | |
| parent | 62570e8626c67f9d38b28246304b938aab9d9fbe (diff) | |
| download | rails-96be08de257460cfd66d7f946be95e07160cea6f.tar.gz rails-96be08de257460cfd66d7f946be95e07160cea6f.tar.bz2 rails-96be08de257460cfd66d7f946be95e07160cea6f.zip | |
Stop find_in_batches using the records after yielding.
Currently if the code that calls .find_in_batches modifies the yielded array in place then .find_in_batches can enter an infinite loop searching with ruby object ids in the database instead of the primary key of records in the database. This happens because it naively assumes the yielded array hasn't been modified before calling #id on the last object in the array. And ruby (1.8 at least) alias' #id to #object_id so an integer is still returned no matter what the last object is.
By moving finding the #id of the last object before yielding the array it means the calling code can do whatever it wants to the array in terms of modifying it in place, and .find_in_batches doesn't care.
Diffstat (limited to 'tasks')
0 files changed, 0 insertions, 0 deletions