Quoting every part of a Range. Calling .to_s is not enough for Range with two Time objects.

2 files changed, 26 insertions, 2 deletions

diff --git a/spec/arel/engines/sql/unit/predicates/in_spec.rb b/spec/arel/engines/sql/unit/predicates/in_spec.rb
index 76e5fc58df..a8ae9e4b5f 100644
--- a/spec/arel/engines/sql/unit/predicates/in_spec.rb
+++ b/spec/arel/engines/sql/unit/predicates/in_spec.rb
@@ -84,6 +84,30 @@ module Arel
           end
         end
 
+        describe 'when relating to a time range' do
+          before do
+            @relation = Arel::Table.new(:developers)
+            @attribute = @relation[:created_at]
+            @range = Time.mktime(2010, 01, 01)..Time.mktime(2010, 02, 01)
+          end
+
+          it 'manufactures sql with a between' do
+            sql = In.new(@attribute, @range).to_sql
+
+            adapter_is :mysql do
+              sql.should be_like(%Q{`developers`.`created_at` BETWEEN '2010-01-01 00:00:00' AND '2010-02-01 00:00:00'})
+            end
+
+            adapter_is :sqlite3 do
+              sql.should be_like(%Q{"developers"."created_at" BETWEEN '2010-01-01 00:00:00' AND '2010-02-01 00:00:00'})
+            end
+
+            adapter_is :postgresql do
+              sql.should be_like(%Q{"developers"."created_at" BETWEEN '2010-01-01 00:00:00.000000' AND '2010-02-01 00:00:00.000000'})
+            end
+          end
+        end
+
         describe 'when relating to a relation' do
           it 'manufactures sql with a subselect' do
             sql = In.new(@attribute, @relation).to_sql
diff --git a/spec/arel/engines/sql/unit/relations/having_spec.rb b/spec/arel/engines/sql/unit/relations/having_spec.rb
index dd170a256f..915ee3af08 100644
--- a/spec/arel/engines/sql/unit/relations/having_spec.rb
+++ b/spec/arel/engines/sql/unit/relations/having_spec.rb
@@ -13,7 +13,7 @@ module Arel
 
           adapter_is :mysql do
             sql.should be_like(%Q{
-              SELECT `developers`.`id`, `developers`.`name`, `developers`.`salary`, `developers`.`department`
+              SELECT `developers`.`id`, `developers`.`name`, `developers`.`salary`, `developers`.`department`, `developers`.`created_at`
               FROM `developers`
               GROUP BY `developers`.`department`
               HAVING MIN(salary) > 1000
@@ -22,7 +22,7 @@ module Arel
 
           adapter_is_not :mysql do
             sql.should be_like(%Q{
-              SELECT "developers"."id", "developers"."name", "developers"."salary", "developers"."department"
+              SELECT "developers"."id", "developers"."name", "developers"."salary", "developers"."department", "developers"."created_at"
               FROM "developers"
               GROUP BY "developers"."department"
               HAVING MIN(salary) > 1000