aboutsummaryrefslogtreecommitdiffstats
path: root/railties
diff options
context:
space:
mode:
authorMatthew Draper <matthew@trebex.net>2016-01-24 16:38:58 +1030
committerMatthew Draper <matthew@trebex.net>2016-01-24 16:38:58 +1030
commite3a0ad83da16f5fb063ce7d254b4e466baf7199d (patch)
tree3a8f3f00d3454788eeb9c96089ee91b658520057 /railties
parent83d2c39d5eb8d82ba124b6725d08c8e90760c764 (diff)
parent693f1beeeebd95e9a825fb5690e5f53ce146733f (diff)
downloadrails-e3a0ad83da16f5fb063ce7d254b4e466baf7199d.tar.gz
rails-e3a0ad83da16f5fb063ce7d254b4e466baf7199d.tar.bz2
rails-e3a0ad83da16f5fb063ce7d254b4e466baf7199d.zip
Merge pull request #23216 from prathamesh-sonpatki/fix-23137
Rails::Generators::Actions#gem should work even if frozen string is passed as argument
Diffstat (limited to 'railties')
-rw-r--r--railties/lib/rails/generators/actions.rb2
-rw-r--r--railties/test/generators/actions_test.rb8
2 files changed, 9 insertions, 1 deletions
diff --git a/railties/lib/rails/generators/actions.rb b/railties/lib/rails/generators/actions.rb
index cd83175da8..9ca731347a 100644
--- a/railties/lib/rails/generators/actions.rb
+++ b/railties/lib/rails/generators/actions.rb
@@ -20,7 +20,7 @@ module Rails
# Set the message to be shown in logs. Uses the git repo if one is given,
# otherwise use name (version).
- parts, message = [ quote(name) ], name
+ parts, message = [ quote(name) ], name.dup
if version ||= options.delete(:version)
parts << quote(version)
message << " (#{version})"
diff --git a/railties/test/generators/actions_test.rb b/railties/test/generators/actions_test.rb
index a1a17d90d8..3300850604 100644
--- a/railties/test/generators/actions_test.rb
+++ b/railties/test/generators/actions_test.rb
@@ -113,6 +113,14 @@ class ActionsTest < Rails::Generators::TestCase
assert_file 'Gemfile', /^gem 'rspec', ">=2\.0'0"$/
end
+ def test_gem_works_even_if_frozen_string_is_passed_as_argument
+ run_generator
+
+ action :gem, "frozen_gem".freeze, "1.0.0".freeze
+
+ assert_file 'Gemfile', /^gem 'frozen_gem', '1.0.0'$/
+ end
+
def test_gem_group_should_wrap_gems_in_a_group
run_generator