diff options
| author | Janko Marohnić <janko.marohnic@gmail.com> | 2018-04-06 01:48:29 +0200 |
|---|---|---|
| committer | Janko Marohnić <janko.marohnic@gmail.com> | 2018-04-18 17:46:25 +0200 |
| commit | ca1296858788780dcb5497e86f66b56170cca279 (patch) | |
| tree | 1a54f8b10b9dd49c8c2c7581515d9efd6073fa7a /railties | |
| parent | 662ba236d115d3e2152b04dcdefdc0ee6f1f6102 (diff) | |
| download | rails-ca1296858788780dcb5497e86f66b56170cca279.tar.gz rails-ca1296858788780dcb5497e86f66b56170cca279.tar.bz2 rails-ca1296858788780dcb5497e86f66b56170cca279.zip | |
Use ImageProcessing gem for ActiveStorage variants
ImageProcessing gem is a wrapper around MiniMagick and ruby-vips, and
implements an interface for common image resizing and processing. This
is the canonical image processing gem recommended in [Shrine], and
that's where it developed from. The initial implementation was extracted
from Refile, which also implements on-the-fly transformations.
Some features that ImageProcessing gem adds on top of MiniMagick:
* resizing macros
- #resize_to_limit
- #resize_to_fit
- #resize_to_fill
- #resize_and_pad
* automatic orientation
* automatic thumbnail sharpening
* avoids the complex and inefficient MiniMagick::Image class
* will use "magick" instead of "convert" on ImageMagick 7
However, the biggest feature of the ImageProcessing gem is that it has
an alternative implementation that uses libvips. Libvips is an
alternative to ImageMagick that can process images very rapidly (we've
seen up 10x faster than ImageMagick).
What's great is that the ImageProcessing gem provides the same interface
for both implementations. The macros are named the same, and the libvips
implementation does auto orientation and thumbnail sharpening as well;
only the operations/options specific to ImageMagick/libvips differ. The
integration provided by this PR should work for both implementations.
The plan is to introduce the ImageProcessing backend in Rails 6.0 as the
default backend and deprecate the MiniMagick backend, then in Rails 6.1
remove the MiniMagick backend.
Diffstat (limited to 'railties')
| -rw-r--r-- | railties/lib/rails/generators/rails/app/templates/Gemfile.tt | 2 | ||||
| -rw-r--r-- | railties/test/generators/app_generator_test.rb | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/railties/lib/rails/generators/rails/app/templates/Gemfile.tt b/railties/lib/rails/generators/rails/app/templates/Gemfile.tt index 5e7455cdc7..1567333023 100644 --- a/railties/lib/rails/generators/rails/app/templates/Gemfile.tt +++ b/railties/lib/rails/generators/rails/app/templates/Gemfile.tt @@ -23,7 +23,7 @@ ruby <%= "'#{RUBY_VERSION}'" -%> <% unless skip_active_storage? -%> # Use ActiveStorage variant -# gem 'mini_magick', '~> 4.8' +# gem 'image_processing', '~> 1.2' <% end -%> # Use Capistrano for deployment diff --git a/railties/test/generators/app_generator_test.rb b/railties/test/generators/app_generator_test.rb index 294fdcd6a1..4fcd4b9ba7 100644 --- a/railties/test/generators/app_generator_test.rb +++ b/railties/test/generators/app_generator_test.rb @@ -312,7 +312,7 @@ class AppGeneratorTest < Rails::Generators::TestCase def test_active_storage_mini_magick_gem run_generator - assert_file "Gemfile", /^# gem 'mini_magick'/ + assert_file "Gemfile", /^# gem 'image_processing'/ end def test_mini_magick_gem_when_skip_active_storage_is_given @@ -320,7 +320,7 @@ class AppGeneratorTest < Rails::Generators::TestCase run_generator [app_root, "--skip-active-storage"] assert_file "#{app_root}/Gemfile" do |content| - assert_no_match(/gem 'mini_magick'/, content) + assert_no_match(/gem 'image_processing'/, content) end end |