diff options
author | Piotr Sarnacki <drogus@gmail.com> | 2012-06-08 19:09:18 +0200 |
---|---|---|
committer | Piotr Sarnacki <drogus@gmail.com> | 2012-06-08 19:56:46 +0200 |
commit | 8475cddc986d9401f1d56c511f79032b5daed7c7 (patch) | |
tree | 3b5d7da427433ab69912fece1f9321fded680ac4 /railties | |
parent | 0e4d16f78f0bb08fa1e8351be97f984f1a5e4f58 (diff) | |
download | rails-8475cddc986d9401f1d56c511f79032b5daed7c7.tar.gz rails-8475cddc986d9401f1d56c511f79032b5daed7c7.tar.bz2 rails-8475cddc986d9401f1d56c511f79032b5daed7c7.zip |
Don't add sqlite3 to gemspec with -O on rails plugin new
(closes #6672)
Diffstat (limited to 'railties')
-rw-r--r-- | railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec | 2 | ||||
-rw-r--r-- | railties/test/generators/plugin_new_generator_test.rb | 8 |
2 files changed, 10 insertions, 0 deletions
diff --git a/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec b/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec index 8588e88077..49e004602a 100644 --- a/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec +++ b/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec @@ -22,6 +22,8 @@ Gem::Specification.new do |s| <% if full? && !options[:skip_javascript] -%> # s.add_dependency "<%= "#{options[:javascript]}-rails" %>" <% end -%> +<% unless options[:skip_active_record] -%> s.add_development_dependency "<%= gem_for_database %>" +<% end -%> end diff --git a/railties/test/generators/plugin_new_generator_test.rb b/railties/test/generators/plugin_new_generator_test.rb index 7569c90955..dcf4f95194 100644 --- a/railties/test/generators/plugin_new_generator_test.rb +++ b/railties/test/generators/plugin_new_generator_test.rb @@ -89,6 +89,14 @@ class PluginNewGeneratorTest < Rails::Generators::TestCase assert_file "bukkits.gemspec", /mysql/ end + def test_dont_generate_development_dependency + run_generator [destination_root, "--skip-active-record"] + + assert_file "bukkits.gemspec" do |contents| + assert_no_match(/s.add_development_dependency "sqlite3"/, contents) + end + end + def test_active_record_is_removed_from_frameworks_if_skip_active_record_is_given run_generator [destination_root, "--skip-active-record"] assert_file "test/dummy/config/application.rb", /#\s+require\s+["']active_record\/railtie["']/ |