diff options
| author | David Heinemeier Hansson <david@loudthinking.com> | 2012-03-13 09:57:51 -0400 |
|---|---|---|
| committer | David Heinemeier Hansson <david@loudthinking.com> | 2012-03-13 09:57:51 -0400 |
| commit | 46313151bd2ff419251543eda1b1122d4cc7c5ed (patch) | |
| tree | 8dc2dc1f04577c7c0b1fdf3a08d4b39986bfcc71 /railties | |
| parent | fc3e9b32fd88e19033c24136d5c06baa1a295084 (diff) | |
| download | rails-46313151bd2ff419251543eda1b1122d4cc7c5ed.tar.gz rails-46313151bd2ff419251543eda1b1122d4cc7c5ed.tar.bz2 rails-46313151bd2ff419251543eda1b1122d4cc7c5ed.zip | |
Undo unwarranted change to coding conventions. I am not a fan of the aesthetics of private/public at the root but more importantly, we should not be changing coding conventions with almost a decades worth of history at a whim. The conventions are there to have a consistent coding style, that is their primary purpose. When there is so much existing code with the existing style, any change will have to lift an enormous burden of proof as to why its overwhelmingly superior. That is not the case here, so this is being reverted.
Diffstat (limited to 'railties')
| -rw-r--r-- | railties/guides/source/contributing_to_ruby_on_rails.textile | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/railties/guides/source/contributing_to_ruby_on_rails.textile b/railties/guides/source/contributing_to_ruby_on_rails.textile index aac5e13978..8d29544edf 100644 --- a/railties/guides/source/contributing_to_ruby_on_rails.textile +++ b/railties/guides/source/contributing_to_ruby_on_rails.textile @@ -310,6 +310,7 @@ Rails follows a simple set of coding style conventions. * Two spaces, no tabs. * No trailing whitespace. Blank lines should not have any space. * Outdent private/protected from method definitions. Same indentation as the class/module. +* Indent after private/protected. * Prefer +&&+/+||+ over +and+/+or+. * Prefer class << self block over self.method for class methods. * +MyClass.my_method(my_arg)+ not +my_method( my_arg )+ or +my_method my_arg+. |