aboutsummaryrefslogtreecommitdiffstats
path: root/railties
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2017-07-24 13:28:38 +0900
committerRyuta Kamizono <kamipo@gmail.com>2017-07-25 03:11:56 +0900
commit45955aed0085c453917aac2e2e5fbe5f3e73f705 (patch)
tree5072b898d6ddd12419395fb277174824cf5f7cfb /railties
parentad3aaadce0f8fb977aa2bd1c551160e83d7dac03 (diff)
downloadrails-45955aed0085c453917aac2e2e5fbe5f3e73f705.tar.gz
rails-45955aed0085c453917aac2e2e5fbe5f3e73f705.tar.bz2
rails-45955aed0085c453917aac2e2e5fbe5f3e73f705.zip
`Relation::Merger` should not fill `values` with empty values
Currently `Relation#merge` will almost fill `values` with empty values (e.g. `other.order_values` is always true, it should be `other.order_values.any?`). This means that `Relation#merge` always changes `values` even if actually `values` is nothing changed. This behavior will makes `Relation#empty_scope?` fragile. So `Relation#merge` should avoid unnecessary changes.
Diffstat (limited to 'railties')
0 files changed, 0 insertions, 0 deletions