diff options
| author | brainopia <brainopia@evilmartians.com> | 2012-01-26 10:04:57 +0400 |
|---|---|---|
| committer | Xavier Noria <fxn@hashref.com> | 2012-01-26 10:58:22 +0100 |
| commit | 3a087b8b5e3da3f8cf5a68b6bd354497810bbbd9 (patch) | |
| tree | 51e444def4645f56b27051287fa40fb46c9011a5 /railties | |
| parent | 36d7af34d6e878a4557ba8a2c282609da2f646ba (diff) | |
| download | rails-3a087b8b5e3da3f8cf5a68b6bd354497810bbbd9.tar.gz rails-3a087b8b5e3da3f8cf5a68b6bd354497810bbbd9.tar.bz2 rails-3a087b8b5e3da3f8cf5a68b6bd354497810bbbd9.zip | |
Fix contributing guide to reflect preferred position on indentation
Fix incorrect recommendation from indenting after private/protected to not.
Based on opinions of @spastorino, @jonleighton, @tenderlove
https://github.com/rails/rails/pull/1838#issuecomment-1440281
https://en.twitter.com/#!/spastorino/status/142054749351575552
https://en.twitter.com/#!/tenderlove/status/142014046445641728
https://en.twitter.com/#!/jonleighton/status/142021813415841794
Diffstat (limited to 'railties')
| -rw-r--r-- | railties/guides/source/contributing_to_ruby_on_rails.textile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/railties/guides/source/contributing_to_ruby_on_rails.textile b/railties/guides/source/contributing_to_ruby_on_rails.textile index 1d4360d5dd..dadacb9b36 100644 --- a/railties/guides/source/contributing_to_ruby_on_rails.textile +++ b/railties/guides/source/contributing_to_ruby_on_rails.textile @@ -309,7 +309,7 @@ Rails follows a simple set of coding style conventions. * Two spaces, no tabs. * No trailing whitespace. Blank lines should not have any space. -* Indent after private/protected. +* Do not indent after private/protected. Private/protected should have the same indentation as the methods around. * Prefer +&&+/+||+ over +and+/+or+. * Prefer class << self block over self.method for class methods. * +MyClass.my_method(my_arg)+ not +my_method( my_arg )+ or +my_method my_arg+. |