aboutsummaryrefslogtreecommitdiffstats
path: root/railties
diff options
context:
space:
mode:
authorPiotr Sarnacki <drogus@gmail.com>2012-05-17 10:19:04 -0700
committerPiotr Sarnacki <drogus@gmail.com>2012-05-17 11:33:40 -0700
commit0f5cc34ab58cda99d1401ecc82e1ebb873838dd7 (patch)
tree43f51fb2b09a3e3ecec6865068786791186edfaa /railties
parent319903bde56bae0f7c83a049bb44377522699bd8 (diff)
downloadrails-0f5cc34ab58cda99d1401ecc82e1ebb873838dd7.tar.gz
rails-0f5cc34ab58cda99d1401ecc82e1ebb873838dd7.tar.bz2
rails-0f5cc34ab58cda99d1401ecc82e1ebb873838dd7.zip
Revert changes related to `bundle install` fixes in `rails new`
Reverted changes: f3482a9 Fix tests in railties 5904295 improve #6318 aed906a prevent using already loaded Gemfile for 'bundle install' In order to fix this, we need a fix in bundler related to GEM_PATH, which will allow to run tests properly. I will get this changes back when it happens.
Diffstat (limited to 'railties')
-rw-r--r--railties/lib/rails/generators/app_base.rb11
-rw-r--r--railties/test/generators/plugin_new_generator_test.rb9
2 files changed, 3 insertions, 17 deletions
diff --git a/railties/lib/rails/generators/app_base.rb b/railties/lib/rails/generators/app_base.rb
index 10ad475d55..2c1742c6be 100644
--- a/railties/lib/rails/generators/app_base.rb
+++ b/railties/lib/rails/generators/app_base.rb
@@ -246,17 +246,8 @@ module Rails
# is easier to silence stdout in the existing test suite this way. The
# end-user gets the bundler commands called anyway, so no big deal.
#
- # We unset temporary bundler variables to load proper bundler and Gemfile.
- #
# Thanks to James Tucker for the Gem tricks involved in this call.
- _bundle_command = Gem.bin_path('bundler', 'bundle')
-
- bundle_bin_path, bundle_gemfile, rubyopt = ENV['BUNDLE_BIN_PATH'], ENV['BUNDLE_GEMFILE'], ENV['RUBYOPT']
- ENV['BUNDLE_BIN_PATH'], ENV['BUNDLE_GEMFILE'], ENV['RUBYOPT'] = "", "", ""
-
- print `"#{Gem.ruby}" "#{_bundle_command}" #{command}`
-
- ENV['BUNDLE_BIN_PATH'], ENV['BUNDLE_GEMFILE'], ENV['RUBYOPT'] = bundle_bin_path, bundle_gemfile, rubyopt
+ print `"#{Gem.ruby}" "#{Gem.bin_path('bundler', 'bundle')}" #{command}`
end
def run_bundle
diff --git a/railties/test/generators/plugin_new_generator_test.rb b/railties/test/generators/plugin_new_generator_test.rb
index b0e1865b26..51374e5f3f 100644
--- a/railties/test/generators/plugin_new_generator_test.rb
+++ b/railties/test/generators/plugin_new_generator_test.rb
@@ -99,13 +99,7 @@ class PluginNewGeneratorTest < Rails::Generators::TestCase
end
def test_generation_runs_bundle_install_with_full_and_mountable
- result = run_generator [destination_root, "--mountable", "--full", "--dev"]
- assert_file "#{destination_root}/Gemfile.lock" do |contents|
- assert_match(/bukkits/, contents)
- end
- assert_match(/run bundle install/, result)
- assert_match(/Using bukkits \(0\.0\.1\)/, result)
- assert_match(/Your bundle is complete/, result)
+ result = run_generator [destination_root, "--mountable", "--full"]
assert_equal 1, result.scan("Your bundle is complete").size
end
@@ -354,3 +348,4 @@ protected
silence(:stdout){ generator.send(*args, &block) }
end
end
+