diff options
author | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2019-02-04 15:56:47 -0500 |
---|---|---|
committer | Rafael Mendonça França <rafaelmfranca@gmail.com> | 2019-02-04 15:56:47 -0500 |
commit | cc2d614e6310337a9d34ede3e67d634d84561cde (patch) | |
tree | 54f65f209f3666477327c4a1bea779990ad7b455 /railties/test | |
parent | 2299d31c4cad93992c6bacba21e01fcdd93e0930 (diff) | |
download | rails-cc2d614e6310337a9d34ede3e67d634d84561cde.tar.gz rails-cc2d614e6310337a9d34ede3e67d634d84561cde.tar.bz2 rails-cc2d614e6310337a9d34ede3e67d634d84561cde.zip |
Improve performance of blank? and present? in an ActiveRecord::Base instance
With this benchmark:
require "bundler/setup"
require "active_record"
require "benchmark/ips"
# This connection will do for database-independent bug reports.
ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")
ActiveRecord::Schema.define do
create_table :posts, force: true do |t|
end
end
class Post < ActiveRecord::Base
end
new_post = Post.new
Benchmark.ips do |b|
b.report("present?") do
new_post.present?
end
b.report("blank?") do
new_post.blank?
end
end
Before:
Warming up --------------------------------------
present? 52.147k i/100ms
blank? 53.077k i/100ms
Calculating -------------------------------------
present? 580.184k (±21.8%) i/s - 2.555M in 5.427085s
blank? 601.537k (± 9.2%) i/s - 2.972M in 5.003503s
After:
Warming up --------------------------------------
present? 378.235k i/100ms
blank? 375.476k i/100ms
Calculating -------------------------------------
present? 17.381M (± 7.5%) i/s - 86.238M in 5.001815s
blank? 17.877M (± 6.4%) i/s - 88.988M in 5.004634s
This improvement is mostly because those methods were hitting
`method_missing` on a lot of levels to be able to return the value.
To avoid all this stack walking we are short-circuiting those methods.
Closes #35059.
Diffstat (limited to 'railties/test')
0 files changed, 0 insertions, 0 deletions