aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
diff options
context:
space:
mode:
authoryuuji.yaginuma <yuuji.yaginuma@gmail.com>2017-06-26 05:46:12 +0900
committeryuuji.yaginuma <yuuji.yaginuma@gmail.com>2017-07-16 08:38:47 +0900
commit5803640261a324bd7d7665a2bad5b5dc6da29255 (patch)
tree725eb7e0f1eba0cf2f00b28df0bf80795f595824 /railties/test
parent5153c0c21daa2f19b01e8ed2738e9f154bd948f7 (diff)
downloadrails-5803640261a324bd7d7665a2bad5b5dc6da29255.tar.gz
rails-5803640261a324bd7d7665a2bad5b5dc6da29255.tar.bz2
rails-5803640261a324bd7d7665a2bad5b5dc6da29255.zip
Do not generate unused components contents in `app:update` task
Currently, `app:update` generates all contents regardless of the component using in application. For example, even if not using Action Cable, `app:update` will generate a contents related to Action Cable. This is a little inconvenient. This PR checks the existence of the component and does not generate unnecessary contents. Can not check all options in this way. However, it will be able to prevent the generation of unnecessary files.
Diffstat (limited to 'railties/test')
-rw-r--r--railties/test/generators/app_generator_test.rb16
1 files changed, 16 insertions, 0 deletions
diff --git a/railties/test/generators/app_generator_test.rb b/railties/test/generators/app_generator_test.rb
index 059c2692be..ffdee3a6b5 100644
--- a/railties/test/generators/app_generator_test.rb
+++ b/railties/test/generators/app_generator_test.rb
@@ -278,6 +278,22 @@ class AppGeneratorTest < Rails::Generators::TestCase
end
end
+ def test_app_update_does_not_generate_action_cable_contents_when_skip_action_cable_is_given
+ app_root = File.join(destination_root, "myapp")
+ run_generator [app_root, "--skip-action-cable"]
+
+ FileUtils.cd(app_root) do
+ # For avoid conflict file
+ FileUtils.rm("#{app_root}/config/secrets.yml")
+ quietly { system("bin/rails app:update") }
+ end
+
+ assert_no_file "#{app_root}/config/cable.yml"
+ assert_file "#{app_root}/config/environments/production.rb" do |content|
+ assert_no_match(/config\.action_cable/, content)
+ end
+ end
+
def test_application_names_are_not_singularized
run_generator [File.join(destination_root, "hats")]
assert_file "hats/config/environment.rb", /Rails\.application\.initialize!/