diff options
author | Washington Luiz <huoxito@gmail.com> | 2014-08-30 19:39:38 -0300 |
---|---|---|
committer | Washington Luiz <huoxito@gmail.com> | 2014-09-02 22:50:50 -0300 |
commit | 435e8d719cadb045cf7b194e2aafa766a67cd4bf (patch) | |
tree | 1ded2f716fec54153c967a51f0bb98d633622fbc /railties/test | |
parent | d233d6e25ea6988f2be5710fa832dc4b18bfc496 (diff) | |
download | rails-435e8d719cadb045cf7b194e2aafa766a67cd4bf.tar.gz rails-435e8d719cadb045cf7b194e2aafa766a67cd4bf.tar.bz2 rails-435e8d719cadb045cf7b194e2aafa766a67cd4bf.zip |
Dont mess with default order engines load
When copying migrations some engines might depend on schema from other
engine so we can't blindly reverse all railties collection as that would
affect the order they were originally loaded. This patch helps to only
apply the order from engines specified in `railties_order`
Diffstat (limited to 'railties/test')
-rw-r--r-- | railties/test/railties/engine_test.rb | 36 |
1 files changed, 36 insertions, 0 deletions
diff --git a/railties/test/railties/engine_test.rb b/railties/test/railties/engine_test.rb index ec64ce5941..1976466229 100644 --- a/railties/test/railties/engine_test.rb +++ b/railties/test/railties/engine_test.rb @@ -144,6 +144,42 @@ module RailtiesTest end end + test "dont reverse default railties order" do + @api = engine "api" do |plugin| + plugin.write "lib/api.rb", <<-RUBY + module Api + class Engine < ::Rails::Engine; end + end + RUBY + end + + # added last but here is loaded before api engine + @core = engine "core" do |plugin| + plugin.write "lib/core.rb", <<-RUBY + module Core + class Engine < ::Rails::Engine; end + end + RUBY + end + + @core.write "db/migrate/1_create_users.rb", <<-RUBY + class CreateUsers < ActiveRecord::Migration; end + RUBY + + @api.write "db/migrate/2_create_keys.rb", <<-RUBY + class CreateKeys < ActiveRecord::Migration; end + RUBY + + boot_rails + + Dir.chdir(app_path) do + output = `bundle exec rake railties:install:migrations`.split("\n") + + assert_match(/Copied migration \d+_create_users.core_engine.rb from core_engine/, output.first) + assert_match(/Copied migration \d+_create_keys.api_engine.rb from api_engine/, output.last) + end + end + test "mountable engine should copy migrations within engine_path" do @plugin.write "lib/bukkits.rb", <<-RUBY module Bukkits |