diff options
| author | Jeremy Daer <jeremydaer@gmail.com> | 2016-04-07 13:16:54 -0700 |
|---|---|---|
| committer | Jeremy Daer <jeremydaer@gmail.com> | 2016-04-07 13:36:50 -0700 |
| commit | 95e06e6682b3bc7f813336142213697eac36e401 (patch) | |
| tree | e7e058cae32134a316ef9c6b4c8344c95067b5ef /railties/test/test_unit/reporter_test.rb | |
| parent | 9c2945f4cc1017fc9424f2e425e4820da1ef33b0 (diff) | |
| download | rails-95e06e6682b3bc7f813336142213697eac36e401.tar.gz rails-95e06e6682b3bc7f813336142213697eac36e401.tar.bz2 rails-95e06e6682b3bc7f813336142213697eac36e401.zip | |
Disallow calling `#deliver_later` after local message modifications.
They would be lost when the delivery job is enqueued, otherwise.
Prevents a common, hard-to-find bug like:
```ruby
message = Notifier.welcome(user, foo)
message.message_id = my_generated_message_id
message.deliver_later
```
The message_id is silently lost here! *Only the mailer arguments are
passed to the delivery job.*
This raises an exception now.
Make modifications to the message within the mailer method or use a
custom Active Job to manage delivery instead of using #deliver_later.
Diffstat (limited to 'railties/test/test_unit/reporter_test.rb')
0 files changed, 0 insertions, 0 deletions