aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/isolation/abstract_unit.rb
diff options
context:
space:
mode:
authorKasper Timm Hansen <kaspth@gmail.com>2019-08-04 01:32:41 +0200
committerKasper Timm Hansen <kaspth@gmail.com>2019-08-04 01:32:41 +0200
commit03e44f93001db97953917e0a100c627e189e2be6 (patch)
tree644d82e33a8b7269bfeb22e7f363cd726a6c97be /railties/test/isolation/abstract_unit.rb
parent6db2c426c0156dd3738673a676261693cfe92a8d (diff)
downloadrails-03e44f93001db97953917e0a100c627e189e2be6.tar.gz
rails-03e44f93001db97953917e0a100c627e189e2be6.tar.bz2
rails-03e44f93001db97953917e0a100c627e189e2be6.zip
Revise credentials diffing flow to use a separate diff command
Didn't like the complicated stuff that happened on credentials:edit. It would append to .gitattributes multiple times. Though I see why it was written that way. I'm cutting off for now, but since this new flow would require each developer to run --enable perhaps this should really be: 1. Developer enrolls Rails app by running `credentials:diff --enable` 2. credentials:edit checks .gitattributes for `diff=rails_credentials` and if the current file is covered by that. 3. If so, set up the "rails_credentials" driver automatically.
Diffstat (limited to 'railties/test/isolation/abstract_unit.rb')
-rw-r--r--railties/test/isolation/abstract_unit.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/railties/test/isolation/abstract_unit.rb b/railties/test/isolation/abstract_unit.rb
index 6077ba3ee7..0fe62df8ba 100644
--- a/railties/test/isolation/abstract_unit.rb
+++ b/railties/test/isolation/abstract_unit.rb
@@ -301,7 +301,7 @@ module TestHelpers
# stderr:: true to pass STDERR output straight to the "real" STDERR.
# By default, the STDERR and STDOUT of the process will be
# combined in the returned string.
- def rails(*args, allow_failure: false, stderr: false, stdin: File::NULL)
+ def rails(*args, allow_failure: false, stderr: false)
args = args.flatten
fork = true
@@ -328,7 +328,7 @@ module TestHelpers
out_read.close
err_read.close if err_read
- $stdin.reopen(stdin, "r")
+ $stdin.reopen(File::NULL, "r")
$stdout.reopen(out_write)
$stderr.reopen(err_write)