diff options
author | Martin Spickermann <spickermann@users.noreply.github.com> | 2018-10-05 01:06:33 +0200 |
---|---|---|
committer | Yuji Yaginuma <yuuji.yaginuma@gmail.com> | 2018-10-05 08:06:33 +0900 |
commit | bd107964197989b5b3ec3395e3ab011bb9d662d7 (patch) | |
tree | 4ecccbd789c4f88b0e6b328740c4a9dd3bd37633 /railties/test/credentials_test.rb | |
parent | c37247e187fd4c93ae572240ec56a3946dfc73c4 (diff) | |
download | rails-bd107964197989b5b3ec3395e3ab011bb9d662d7.tar.gz rails-bd107964197989b5b3ec3395e3ab011bb9d662d7.tar.bz2 rails-bd107964197989b5b3ec3395e3ab011bb9d662d7.zip |
Bugfix: ActiveSupport::EncryptedConfiguration reading of comment-only encrypted files (#34014)
* Fix reading comment only encrypted files
When a encrypted file contains only comments then reading that files raises an error:
NoMethodError: undefined method `deep_symbolize_keys' for false:FalseClass
activesupport/lib/active_support/encrypted_configuration.rb:33:in `config'
test/encrypted_configuration_test.rb:52:in `block in <class:EncryptedConfigurationTest>'
This happens because the previous implementation returned a `{}` fallback for blank YAML strings. But it did not handle YAML strings that are present but still do not contain any _usefull_ YAML - like the file created by `Rails::Generators::EncryptedFileGenerator` which looks like this:
# aws:
# access_key_id: 123
# secret_access_key: 345
* Fix coding style violation
* Add backwardscompatible with Psych versions that were shipped with Ruby <2.5
* Do not rely on railties for Active Support test
* Simplify error handling
* Improve test naming
* Simplify file creation in test
Diffstat (limited to 'railties/test/credentials_test.rb')
0 files changed, 0 insertions, 0 deletions