diff options
author | Dillon Welch <daw0328@gmail.com> | 2018-03-29 19:29:55 -0700 |
---|---|---|
committer | Dillon Welch <daw0328@gmail.com> | 2018-07-23 15:37:06 -0700 |
commit | d108288c2f684233298f97f18ac00de0b016deaa (patch) | |
tree | 0656fd6f20d662d854a3fc93e80dfbc0baec063d /railties/test/commands | |
parent | a4398e412c042b297039cc216f6536b0c048bd9c (diff) | |
download | rails-d108288c2f684233298f97f18ac00de0b016deaa.tar.gz rails-d108288c2f684233298f97f18ac00de0b016deaa.tar.bz2 rails-d108288c2f684233298f97f18ac00de0b016deaa.zip |
Turn on performance based cops
Use attr_reader/attr_writer instead of methods
method is 12% slower
Use flat_map over map.flatten(1)
flatten is 66% slower
Use hash[]= instead of hash.merge! with single arguments
merge! is 166% slower
See https://github.com/rails/rails/pull/32337 for more conversation
Diffstat (limited to 'railties/test/commands')
-rw-r--r-- | railties/test/commands/console_test.rb | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/railties/test/commands/console_test.rb b/railties/test/commands/console_test.rb index b7cdb8229e..0b2fe204f8 100644 --- a/railties/test/commands/console_test.rb +++ b/railties/test/commands/console_test.rb @@ -151,7 +151,8 @@ class Rails::ConsoleTest < ActiveSupport::TestCase def build_app(console) mocked_console = Class.new do - attr_reader :sandbox, :console + attr_accessor :sandbox + attr_reader :console def initialize(console) @console = console @@ -161,10 +162,6 @@ class Rails::ConsoleTest < ActiveSupport::TestCase self end - def sandbox=(arg) - @sandbox = arg - end - def load_console end end |