Enable `Style/RedundantBegin` cop to avoid newly adding redundant begin block

Currently we sometimes find a redundant begin block in code review
(e.g. https://github.com/rails/rails/pull/33604#discussion_r209784205).

I'd like to enable `Style/RedundantBegin` cop to avoid that, since
rescue/else/ensure are allowed inside do/end blocks in Ruby 2.5
(https://bugs.ruby-lang.org/issues/12906), so we'd probably meets with
that situation than before.

2 files changed, 10 insertions, 14 deletions

diff --git a/railties/test/commands/dbconsole_test.rb b/railties/test/commands/dbconsole_test.rb
index 5e3eca6585..ce048ac527 100644
--- a/railties/test/commands/dbconsole_test.rb
+++ b/railties/test/commands/dbconsole_test.rb
@@ -308,11 +308,9 @@ class Rails::DBConsoleTest < ActiveSupport::TestCase
     def capture_abort
       @aborted = false
       @output = capture(:stderr) do
-        begin
-          yield
-        rescue SystemExit
-          @aborted = true
-        end
+        yield
+      rescue SystemExit
+        @aborted = true
       end
     end
 
diff --git a/railties/test/commands/routes_test.rb b/railties/test/commands/routes_test.rb
index 693e532c5b..9efab27b38 100644
--- a/railties/test/commands/routes_test.rb
+++ b/railties/test/commands/routes_test.rb
@@ -161,19 +161,18 @@ class Rails::Command::RoutesTest < ActiveSupport::TestCase
   end
 
   test "rails routes with expanded option" do
-    begin
-      previous_console_winsize = IO.console.winsize
-      IO.console.winsize = [0, 27]
+    previous_console_winsize = IO.console.winsize
+    IO.console.winsize = [0, 27]
 
-      app_file "config/routes.rb", <<-RUBY
+    app_file "config/routes.rb", <<-RUBY
         Rails.application.routes.draw do
           get '/cart', to: 'cart#show'
         end
       RUBY
 
-      output = run_routes_command(["--expanded"])
+    output = run_routes_command(["--expanded"])
 
-      assert_equal <<~MESSAGE, output
+    assert_equal <<~MESSAGE, output
         --[ Route 1 ]--------------
         Prefix            | cart
         Verb              | GET
@@ -205,9 +204,8 @@ class Rails::Command::RoutesTest < ActiveSupport::TestCase
         URI               | /rails/active_storage/direct_uploads(.:format)
         Controller#Action | active_storage/direct_uploads#create
       MESSAGE
-    ensure
-      IO.console.winsize = previous_console_winsize
-    end
+  ensure
+    IO.console.winsize = previous_console_winsize
   end
 
   private