aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/commands
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2018-03-29 06:52:04 +0900
committerRyuta Kamizono <kamipo@gmail.com>2019-02-06 00:37:08 +0900
commit2935d07569337aeaa06d03a56180d235a7fbbebf (patch)
tree6546991716de14af2b40aaa60cb1ecf6bcbd9853 /railties/test/commands
parent44232b485485634d681c60868c619323f882e59f (diff)
downloadrails-2935d07569337aeaa06d03a56180d235a7fbbebf.tar.gz
rails-2935d07569337aeaa06d03a56180d235a7fbbebf.tar.bz2
rails-2935d07569337aeaa06d03a56180d235a7fbbebf.zip
Chaining named scope is no longer leaking to class level querying methods
Active Record uses `scoping` to delegate to named scopes from relations for propagating the chaining source scope. It was needed to restore the source scope in named scopes, but it was caused undesired behavior that pollute all class level querying methods. Example: ```ruby class Topic < ActiveRecord::Base scope :toplevel, -> { where(parent_id: nil) } scope :children, -> { where.not(parent_id: nil) } scope :has_children, -> { where(id: Topic.children.select(:parent_id)) } end # Works as expected. Topic.toplevel.where(id: Topic.children.select(:parent_id)) # Doesn't work due to leaking `toplevel` to `Topic.children`. Topic.toplevel.has_children ``` Since #29301, the receiver in named scopes has changed from the model class to the chaining source scope, so the polluting class level querying methods is no longer required for that purpose. Fixes #14003.
Diffstat (limited to 'railties/test/commands')
0 files changed, 0 insertions, 0 deletions