diff options
author | Patrick Toomey <ptoomey3@biasedcoin.com> | 2018-07-26 10:29:57 -0600 |
---|---|---|
committer | Patrick Toomey <ptoomey3@biasedcoin.com> | 2018-07-30 16:33:34 -0600 |
commit | 84e8b350a3c3b9dbf4333fb21979688b3eb1f19e (patch) | |
tree | a3d89d4186e7f39936b0527c7107c4c970d53192 /railties/test/application/rack/logger_test.rb | |
parent | 15a72c6c05cfc5250ee04742b4f45463f937d3f7 (diff) | |
download | rails-84e8b350a3c3b9dbf4333fb21979688b3eb1f19e.tar.gz rails-84e8b350a3c3b9dbf4333fb21979688b3eb1f19e.tar.bz2 rails-84e8b350a3c3b9dbf4333fb21979688b3eb1f19e.zip |
Raises exception when respond_to called multiple times in incompatible way
Nesting respond_to calls can lead to unexpected behavior, so it should be
avoided. Currently, the first respond_to format match sets the content-type
for the resulting response. But, if a nested respond_to occurs, it is possible
to match on a different format. For example:
respond_to do |outer_type|
outer_type.js do
respond_to do |inner_type|
inner_type.html { render body: "HTML" }
end
end
end
Browsers will often include */* in their Accept headers. In the above example,
such a request would result in the outer_type.js match setting the content-
type of the response to text/javascript, while the inner_type.html match will
cause the actual response to return "HTML".
This change tries to minimize potential breakage by only raising an exception
if the nested respond_to calls are in conflict with each other. So, something
like the following example would not raise an exception:
respond_to do |outer_type|
outer_type.js do
respond_to do |inner_type|
inner_type.js { render body: "JS" }
end
end
end
While the above is nested, it doesn't affect the content-type of the response.
Diffstat (limited to 'railties/test/application/rack/logger_test.rb')
0 files changed, 0 insertions, 0 deletions