diff options
| author | Dillon Welch <daw0328@gmail.com> | 2018-03-29 19:29:55 -0700 |
|---|---|---|
| committer | Dillon Welch <daw0328@gmail.com> | 2018-07-23 15:37:06 -0700 |
| commit | d108288c2f684233298f97f18ac00de0b016deaa (patch) | |
| tree | 0656fd6f20d662d854a3fc93e80dfbc0baec063d /railties/test/app_loader_test.rb | |
| parent | a4398e412c042b297039cc216f6536b0c048bd9c (diff) | |
| download | rails-d108288c2f684233298f97f18ac00de0b016deaa.tar.gz rails-d108288c2f684233298f97f18ac00de0b016deaa.tar.bz2 rails-d108288c2f684233298f97f18ac00de0b016deaa.zip | |
Turn on performance based cops
Use attr_reader/attr_writer instead of methods
method is 12% slower
Use flat_map over map.flatten(1)
flatten is 66% slower
Use hash[]= instead of hash.merge! with single arguments
merge! is 166% slower
See https://github.com/rails/rails/pull/32337 for more conversation
Diffstat (limited to 'railties/test/app_loader_test.rb')
| -rw-r--r-- | railties/test/app_loader_test.rb | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/railties/test/app_loader_test.rb b/railties/test/app_loader_test.rb index 93ed68fabb..0deb1a76df 100644 --- a/railties/test/app_loader_test.rb +++ b/railties/test/app_loader_test.rb @@ -9,12 +9,12 @@ class AppLoaderTest < ActiveSupport::TestCase @loader ||= Class.new do extend Rails::AppLoader - def self.exec_arguments - @exec_arguments - end + class << self + attr_accessor :exec_arguments - def self.exec(*args) - @exec_arguments = args + def exec(*args) + self.exec_arguments = args + end end end end |