diff options
author | Javan Makhmali <javan@javan.us> | 2019-01-16 17:09:53 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-01-16 17:09:53 -0500 |
commit | a5fee7d531c06176ecc8815f52d9d54050c274ce (patch) | |
tree | 11631db8b66c8d7d272dda11c715aeb253eb2ecc /railties/lib/rails | |
parent | 90536ebfb3f0ca6971bc3ea4e43f20b8e977539b (diff) | |
parent | 385d31d209a957946378307e50aa739ccfadfea1 (diff) | |
download | rails-a5fee7d531c06176ecc8815f52d9d54050c274ce.tar.gz rails-a5fee7d531c06176ecc8815f52d9d54050c274ce.tar.bz2 rails-a5fee7d531c06176ecc8815f52d9d54050c274ce.zip |
Merge pull request #34949 from javan/js/compact-start
Minimize boilerplate setup code for JavaScript libraries
Diffstat (limited to 'railties/lib/rails')
-rw-r--r-- | railties/lib/rails/generators/rails/app/templates/app/javascript/channels/consumer.js | 4 | ||||
-rw-r--r-- | railties/lib/rails/generators/rails/app/templates/app/javascript/packs/application.js.tt | 14 |
2 files changed, 6 insertions, 12 deletions
diff --git a/railties/lib/rails/generators/rails/app/templates/app/javascript/channels/consumer.js b/railties/lib/rails/generators/rails/app/templates/app/javascript/channels/consumer.js index eec7e54b8a..0eceb59b18 100644 --- a/railties/lib/rails/generators/rails/app/templates/app/javascript/channels/consumer.js +++ b/railties/lib/rails/generators/rails/app/templates/app/javascript/channels/consumer.js @@ -1,6 +1,6 @@ // Action Cable provides the framework to deal with WebSockets in Rails. // You can generate new channels where WebSocket features live using the `rails generate channel` command. -import ActionCable from "@rails/actioncable" +import { createConsumer } from "@rails/actioncable" -export default ActionCable.createConsumer() +export default createConsumer() diff --git a/railties/lib/rails/generators/rails/app/templates/app/javascript/packs/application.js.tt b/railties/lib/rails/generators/rails/app/templates/app/javascript/packs/application.js.tt index de91713546..908487d500 100644 --- a/railties/lib/rails/generators/rails/app/templates/app/javascript/packs/application.js.tt +++ b/railties/lib/rails/generators/rails/app/templates/app/javascript/packs/application.js.tt @@ -3,19 +3,13 @@ // a relevant structure within app/javascript and only use these pack files to reference // that code so it'll be compiled. -import Rails from "@rails/ujs" -Rails.start() +require("@rails/ujs").start() <%- unless options[:skip_turbolinks] -%> - -import Turbolinks from "turbolinks" -Turbolinks.start() +require("turbolinks").start() <%- end -%> <%- unless skip_active_storage? -%> - -import * as ActiveStorage from "@rails/activestorage" -ActiveStorage.start() +require("@rails/activestorage").start() <%- end -%> <%- unless options[:skip_action_cable] -%> - -import "channels" +require("channels") <%- end -%> |