aboutsummaryrefslogtreecommitdiffstats
path: root/railties/lib/rails/commands/dbconsole/dbconsole_command.rb
diff options
context:
space:
mode:
authorRobin Dupret <robin.dupret@gmail.com>2017-06-05 23:19:00 +0200
committerRobin Dupret <robin.dupret@gmail.com>2017-07-16 14:39:09 +0200
commit1acd9a6464668d4d54ab30d016829f60b70dbbeb (patch)
tree4723a83664338541f6cfd8d49f8dbb0ebbc0466d /railties/lib/rails/commands/dbconsole/dbconsole_command.rb
parent16f2b2044eaaa54b7bc205ef9af1689a152b2fdf (diff)
downloadrails-1acd9a6464668d4d54ab30d016829f60b70dbbeb.tar.gz
rails-1acd9a6464668d4d54ab30d016829f60b70dbbeb.tar.bz2
rails-1acd9a6464668d4d54ab30d016829f60b70dbbeb.zip
Allow to pass a connection to the `dbconsole` command
Since 0a4f6009, it's possible to specify a 3-level database configuration to gather connections by environment. The `dbconsole` command will try to look for a database configuration which points to the current environment but with such flavour, the environment key is flushed out so let's add the ability to specify the connection and pick `primary` by default to be consistent with Active Record.
Diffstat (limited to 'railties/lib/rails/commands/dbconsole/dbconsole_command.rb')
-rw-r--r--railties/lib/rails/commands/dbconsole/dbconsole_command.rb16
1 files changed, 14 insertions, 2 deletions
diff --git a/railties/lib/rails/commands/dbconsole/dbconsole_command.rb b/railties/lib/rails/commands/dbconsole/dbconsole_command.rb
index b3df5191c6..383149eb81 100644
--- a/railties/lib/rails/commands/dbconsole/dbconsole_command.rb
+++ b/railties/lib/rails/commands/dbconsole/dbconsole_command.rb
@@ -87,10 +87,15 @@ module Rails
def config
@config ||= begin
- if configurations[environment].blank?
+ # We need to check whether the user passed the connection the
+ # first time around to show a consistent error message to people
+ # relying on 2-level database configuration.
+ if @options["connection"] && configurations[connection].blank?
+ raise ActiveRecord::AdapterNotSpecified, "'#{connection}' connection is not configured. Available configuration: #{configurations.inspect}"
+ elsif configurations[environment].blank? && configurations[connection].blank?
raise ActiveRecord::AdapterNotSpecified, "'#{environment}' database is not configured. Available configuration: #{configurations.inspect}"
else
- configurations[environment]
+ configurations[environment].presence || configurations[connection]
end
end
end
@@ -99,6 +104,10 @@ module Rails
Rails.respond_to?(:env) ? Rails.env : Rails::Command.environment
end
+ def connection
+ @options.fetch(:connection, "primary")
+ end
+
private
def configurations # :doc:
require APP_PATH
@@ -145,6 +154,9 @@ module Rails
class_option :environment, aliases: "-e", type: :string,
desc: "Specifies the environment to run this console under (test/development/production)."
+ class_option :connection, aliases: "-c", type: :string,
+ desc: "Specifies the connection to use."
+
def perform
extract_environment_option_from_argument