aboutsummaryrefslogtreecommitdiffstats
path: root/railties/CHANGELOG.md
diff options
context:
space:
mode:
authorKasper Timm Hansen <kaspth@gmail.com>2017-06-25 19:08:26 +0200
committerKasper Timm Hansen <kaspth@gmail.com>2017-07-10 20:40:16 +0200
commit0d72489b2a08487f71dd4230846c01a5d99ef35f (patch)
tree361e00c0c82de24f359bbe5ba32b76d9913c609e /railties/CHANGELOG.md
parentb6300f3ecc79bff29cf9bb804a30fd92403feac1 (diff)
downloadrails-0d72489b2a08487f71dd4230846c01a5d99ef35f.tar.gz
rails-0d72489b2a08487f71dd4230846c01a5d99ef35f.tar.bz2
rails-0d72489b2a08487f71dd4230846c01a5d99ef35f.zip
* Don't eagerly require Rails' minitest plugin.
By making the Rails minitest behave like a standard minitest plugin we're much more likely to not break when people use other minitest plugins. Like minitest-focus and pride. To do this, we need to behave like minitest: require files up front and then perform the plugin behavior via the at_exit hook. This also saves us a fair bit of wrangling with test file loading. Finally, since the environment and warnings options have to be applied as early as possible, and since minitest loads plugins at_exit, they have to be moved to the test command. * Don't expect the root method. It's likely this worked because we eagerly loaded the Rails minitest plugin and that somehow defined a root method on `Rails`. * Assign a backtrace to failed exceptions. Otherwise Minitest pukes when attempting to filter the backtrace (which Rails' backtrace cleaner then removes). Means the exception message test has to be revised too. This is likely caused by the rails minitest plugin now being loaded for these tests and assigning a default backtrace cleaner.
Diffstat (limited to 'railties/CHANGELOG.md')
-rw-r--r--railties/CHANGELOG.md8
1 files changed, 8 insertions, 0 deletions
diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md
index d793405da1..761e2f4ded 100644
--- a/railties/CHANGELOG.md
+++ b/railties/CHANGELOG.md
@@ -1,3 +1,11 @@
+* Make Rails' test runner work better with minitest plugins.
+
+ By demoting the Rails test runner to just another minitest plugin —
+ and thereby not eager loading it — we can co-exist much better with
+ other minitest plugins such as pride and minitest-focus.
+
+ *Kasper Timm Hansen*
+
* Load environment file in `dbconsole` command.
Fixes #29717