diff options
| author | Nick Kallen <nkallen@nick-kallens-computer-2.local> | 2008-05-05 23:15:32 -0700 |
|---|---|---|
| committer | Nick Kallen <nkallen@nick-kallens-computer-2.local> | 2008-05-05 23:15:32 -0700 |
| commit | f22ea4dd5b20c979dbacf8fd5768659e9e4d0706 (patch) | |
| tree | cf1588512938f3c892a4afc1f00871d49e63f03f /lib/arel/relations/relation.rb | |
| parent | 680e080bb4399312f63a699d2f103632b41be927 (diff) | |
| download | rails-f22ea4dd5b20c979dbacf8fd5768659e9e4d0706.tar.gz rails-f22ea4dd5b20c979dbacf8fd5768659e9e4d0706.tar.bz2 rails-f22ea4dd5b20c979dbacf8fd5768659e9e4d0706.zip | |
performance optimization
Diffstat (limited to 'lib/arel/relations/relation.rb')
| -rw-r--r-- | lib/arel/relations/relation.rb | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/lib/arel/relations/relation.rb b/lib/arel/relations/relation.rb index cd58f0f15c..fc47a129a0 100644 --- a/lib/arel/relations/relation.rb +++ b/lib/arel/relations/relation.rb @@ -138,12 +138,21 @@ module Arel def attribute_for_name(name) attributes.detect { |a| a.alias_or_name.to_s == name.to_s } end - + + # TESTME - added relation_for(x)[x] because of AR def attribute_for_attribute(attribute) attributes.select { |a| a =~ attribute }.max do |a1, a2| - (attribute / a1) <=> (attribute / a2) + (attribute / relation_for(a1)[a1]) <=> (attribute / relation_for(a2)[a2]) + end + end + + def attribute_for_attribute_with_memoization(attribute) + @attribute_for_attribute ||= Hash.new do |h, a| + h[a] = attribute_for_attribute_without_memoization(a) end + @attribute_for_attribute[attribute] end + alias_method_chain :attribute_for_attribute, :memoization end include AttributeAccessable |