diff options
author | David Heinemeier Hansson <david@loudthinking.com> | 2017-07-06 15:38:01 +0200 |
---|---|---|
committer | David Heinemeier Hansson <david@loudthinking.com> | 2017-07-06 15:38:01 +0200 |
commit | 152c4b07248d4aed4b734721bd634e546a89ef19 (patch) | |
tree | da0003f340d2294a14d15cc2bc7773c935600298 /lib/active_storage/service/gcs_service.rb | |
parent | 6de714a0ea755caafe5758e232582573ac9966a4 (diff) | |
download | rails-152c4b07248d4aed4b734721bd634e546a89ef19.tar.gz rails-152c4b07248d4aed4b734721bd634e546a89ef19.tar.bz2 rails-152c4b07248d4aed4b734721bd634e546a89ef19.zip |
Compute checksum and byte_size client side
Then we can add integrity checks on uploads to prevent errors in
transport.
Diffstat (limited to 'lib/active_storage/service/gcs_service.rb')
-rw-r--r-- | lib/active_storage/service/gcs_service.rb | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/lib/active_storage/service/gcs_service.rb b/lib/active_storage/service/gcs_service.rb index c2f520d996..c725afb35c 100644 --- a/lib/active_storage/service/gcs_service.rb +++ b/lib/active_storage/service/gcs_service.rb @@ -28,27 +28,13 @@ class ActiveStorage::Service::GCSService < ActiveStorage::Service file_for(key).present? end - def url(key, expires_in:, disposition:, filename:) file_for(key).signed_url(expires: expires_in) + "&" + { "response-content-disposition" => "#{disposition}; filename=\"#{filename}\"" }.to_query end - def byte_size(key) - file_for(key).size - end - - def checksum(key) - convert_to_hex base64: file_for(key).md5 - end - - private def file_for(key) bucket.file(key) end - - def convert_to_hex(base64:) - base64.unpack("m0").first.unpack("H*").first - end end |