Merge pull request #18 from mperham/param_whitelist

Whitelist legal job parameter types

1 files changed, 7 insertions, 3 deletions

diff --git a/lib/active_job/parameters.rb b/lib/active_job/parameters.rb
index a4841abd1e..75de5bcae7 100644
--- a/lib/active_job/parameters.rb
+++ b/lib/active_job/parameters.rb
@@ -3,13 +3,17 @@ require 'active_support/core_ext/object/try'
 
 module ActiveJob
   class Parameters
+    TYPE_WHITELIST = [NilClass, Fixnum, Float, String, TrueClass, FalseClass, Hash, Array]
+
     def self.serialize(params)
-      params.collect { |param| param.try(:global_id) || param }
+      params.collect do |param|
+        raise "Unsupported parameter type: #{param.class.name}" unless param.respond_to?(:global_id) || TYPE_WHITELIST.include?(param.class)
+        param.try(:global_id) || param
+      end
     end
-    
+
     def self.deserialize(params)
       params.collect { |param| ActiveModel::GlobalLocator.locate(param) || param }
     end
   end
 end
-  
\ No newline at end of file