diff options
author | Lachlan Sylvester <lachlan.sylvester@hypothetical.com.au> | 2015-11-18 22:53:23 +1100 |
---|---|---|
committer | Lachlan Sylvester <lachlan.sylvester@hypothetical.com.au> | 2015-11-18 22:53:23 +1100 |
commit | 43c6c7787954d959347a1f90d71b11ba0cb7a8c7 (patch) | |
tree | 55c6f4070655dcf88e8c33e80f50b2be333a6470 /lib/action_cable/server | |
parent | 6be2604aa719713c602b8a873337d328196f8f57 (diff) | |
download | rails-43c6c7787954d959347a1f90d71b11ba0cb7a8c7.tar.gz rails-43c6c7787954d959347a1f90d71b11ba0cb7a8c7.tar.bz2 rails-43c6c7787954d959347a1f90d71b11ba0cb7a8c7.zip |
Handle cases where logger is not a tagged logger.
Previously, a TaggedLoggerProxy was only created if the logger responded to
:tagged, but was still used as if it was a TaggedLoggerProxy elsewhere in the
code, causing undefined method errors.
This moved the check for tagging abilities inside the TaggedLoggerProxy so the
code can always tread the logger like a tagged logger, and if it is not a
tagged logger the tags will just be ignored. This prevents needing to check
if the logger is tagged every time we use it.
Diffstat (limited to 'lib/action_cable/server')
-rw-r--r-- | lib/action_cable/server/worker/active_record_connection_management.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/action_cable/server/worker/active_record_connection_management.rb b/lib/action_cable/server/worker/active_record_connection_management.rb index 1ede0095f8..ecece4e270 100644 --- a/lib/action_cable/server/worker/active_record_connection_management.rb +++ b/lib/action_cable/server/worker/active_record_connection_management.rb @@ -12,7 +12,7 @@ module ActionCable end def with_database_connections - ActiveRecord::Base.logger.tagged(*connection.logger.tags) { yield } + connection.logger.tag(ActiveRecord::Base.logger) { yield } ensure ActiveRecord::Base.clear_active_connections! end |