diff options
author | Pratik Naik <pratiknaik@gmail.com> | 2015-11-04 17:22:48 -0600 |
---|---|---|
committer | Pratik Naik <pratiknaik@gmail.com> | 2015-11-04 17:22:48 -0600 |
commit | cb4ef80f20a23e9c42876b039d8af7d02fd416fb (patch) | |
tree | 5e8c2eaf367a9ee395f1213624ad42a08cbf4f06 /lib/action_cable/connection | |
parent | ee06b33e19019e771f0305a40b15885c22499a8b (diff) | |
parent | 7c1631fa48b8862f37d1026b4f0cf1061dd6947a (diff) | |
download | rails-cb4ef80f20a23e9c42876b039d8af7d02fd416fb.tar.gz rails-cb4ef80f20a23e9c42876b039d8af7d02fd416fb.tar.bz2 rails-cb4ef80f20a23e9c42876b039d8af7d02fd416fb.zip |
Merge branch 'master' into subscription-rejection
Diffstat (limited to 'lib/action_cable/connection')
-rw-r--r-- | lib/action_cable/connection/base.rb | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/lib/action_cable/connection/base.rb b/lib/action_cable/connection/base.rb index b3de4dd4a9..a988060d56 100644 --- a/lib/action_cable/connection/base.rb +++ b/lib/action_cable/connection/base.rb @@ -56,7 +56,7 @@ module ActionCable def initialize(server, env) @server, @env = server, env - @logger = new_tagged_logger + @logger = new_tagged_logger || server.logger @websocket = ActionCable::Connection::WebSocket.new(env) @subscriptions = ActionCable::Connection::Subscriptions.new(self) @@ -151,7 +151,6 @@ module ActionCable server.add_connection(self) rescue ActionCable::Connection::Authorization::UnauthorizedError respond_to_invalid_request - close end def on_message(message) @@ -186,6 +185,8 @@ module ActionCable end def respond_to_invalid_request + close if websocket.alive? + logger.info finished_request_message [ 404, { 'Content-Type' => 'text/plain' }, [ 'Page not found' ] ] end @@ -193,8 +194,10 @@ module ActionCable # Tags are declared in the server but computed in the connection. This allows us per-connection tailored tags. def new_tagged_logger - TaggedLoggerProxy.new server.logger, - tags: server.config.log_tags.map { |tag| tag.respond_to?(:call) ? tag.call(request) : tag.to_s.camelize } + if server.logger.respond_to?(:tagged) + TaggedLoggerProxy.new server.logger, + tags: server.config.log_tags.map { |tag| tag.respond_to?(:call) ? tag.call(request) : tag.to_s.camelize } + end end def started_request_message |