diff options
author | Andrew White <andrew.white@unboxed.co> | 2017-04-18 11:02:05 +0100 |
---|---|---|
committer | Andrew White <andrew.white@unboxed.co> | 2017-04-18 11:02:05 +0100 |
commit | 8776a7139757d0b264785c774d4e7f37d4bc1ac7 (patch) | |
tree | 63f4912b39ad1c9a11fa65576cfbea5470884bd4 /guides | |
parent | 0d208e02f6b90fd3d61da60e58854b9fdd8eeb1d (diff) | |
download | rails-8776a7139757d0b264785c774d4e7f37d4bc1ac7.tar.gz rails-8776a7139757d0b264785c774d4e7f37d4bc1ac7.tar.bz2 rails-8776a7139757d0b264785c774d4e7f37d4bc1ac7.zip |
Use more specific check for :format in route path
The current check for whether to add an optional format to the path
is very lax and will match things like `:format_id` where there are
nested resources, e.g:
resources :formats do
resources :items
end
Fix this by using a more restrictive regex pattern that looks for
the patterns `(.:format)`, `.:format` or `/` at the end of the path.
Note that we need to allow for multiple closing parenthesis since
the route may be of this form:
get "/books(/:action(.:format))", controller: "books"
This probably isn't what's intended since it means that the default
index action route doesn't support a format but we have a test for
it so we need to allow it.
Fixes #28517.
Diffstat (limited to 'guides')
0 files changed, 0 insertions, 0 deletions